Skip to content

Cluster modifications delete cluster members #245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
cosmikwolf opened this issue Sep 24, 2024 · 0 comments · Fixed by #247
Closed

Cluster modifications delete cluster members #245

cosmikwolf opened this issue Sep 24, 2024 · 0 comments · Fixed by #247
Labels
bug Something isn't working

Comments

@cosmikwolf
Copy link
Contributor

cosmikwolf commented Sep 24, 2024

I have a vendor supplied SVD (mspm0g350x)

  <peripherals>
    <peripheral>
     <name>I2C0</name>
    < ... more attributes />
      <registers>
        <cluster>
          <dim>1</dim>
          <dimIncrement>0x18</dimIncrement>
          <dimArrayIndex/>
          <name>I2C0_GPRCM[%s]</name>
          <addressOffset>0x800</addressOffset>
          <register>
            <name>I2C0_PWREN</name>
           </register>
          ... more registers />
        </cluster>
      </registers>
    </peripheral>
  </peripherals>
                

Modifying the cluster size results in removing all the cluster elements:

I2C0:
  _modify:
    "I2C0_GPRCM\\[%s\\]":
      dim: 4

when I run with --post-validate I get this error:

fsh ❯ svdtools patch MSPM0G350X_patch.yml --post-validate
[2024-09-24T22:20:39Z ERROR svdtools::cli] by svdtools (0.3.18)
    
    Caused by:
        0: `Cluster error: Cluster must contain at least one Register or Cluster
        1: Cluster must contain at least one Register or Cluster

Attaching the svd as there were some modifications that I needed to make before I could even process it with svdtools
This is the command I needed to run to get the svd file to be processed by svdtools to begin with:
sed -e 's/read-writeonce/read-writeOnce/g' MSPM0G350X.svd

MSPM0G350X.svd.zip

@cosmikwolf cosmikwolf changed the title Ability to Uncluster, Cluster modifications broken Cluster modifications broken Sep 24, 2024
@cosmikwolf cosmikwolf changed the title Cluster modifications broken Cluster modifications delete cluster members Sep 24, 2024
@burrbull burrbull added the bug Something isn't working label Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants