Skip to content

Commit 5f40942

Browse files
committed
Remove a FIXME comment.
It is possible to avoid the clone as suggested in the comment. It would require introducing an enum with two variants `CloneBeforeModifying(&Domain)` and `Modifiable(&mut Domain)`. But it's not worth the effort, because this code path just isn't very hot. E.g. when compiling a large benchmark like `cargo-0.60.0` it's only hit a few thousand times.
1 parent 83f3d20 commit 5f40942

File tree

1 file changed

+0
-2
lines changed

1 file changed

+0
-2
lines changed

compiler/rustc_mir_dataflow/src/framework/direction.rs

-2
Original file line numberDiff line numberDiff line change
@@ -76,8 +76,6 @@ impl Direction for Backward {
7676
for pred in body.basic_blocks.predecessors()[block].iter().copied() {
7777
match body[pred].terminator().kind {
7878
// Apply terminator-specific edge effects.
79-
//
80-
// FIXME(ecstaticmorse): Avoid cloning the exit state unconditionally.
8179
mir::TerminatorKind::Call { destination, target: Some(dest), .. }
8280
if dest == block =>
8381
{

0 commit comments

Comments
 (0)