Skip to content

Commit 92fac5c

Browse files
authored
clarify message for non-obvious precedence (rust-lang#14043)
I ran across this message while writing code and thought it was quite odd. I've simplified it and hopefully made it clearer for non-native English speakers. changelog: clarify message for non-obvious precedence
2 parents 2c8d1ae + 2f2d09a commit 92fac5c

File tree

2 files changed

+12
-12
lines changed

2 files changed

+12
-12
lines changed

clippy_lints/src/precedence.rs

+1-1
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ impl EarlyLintPass for Precedence {
4343
cx,
4444
PRECEDENCE,
4545
expr.span,
46-
"operator precedence can trip the unwary",
46+
"operator precedence might not be obvious",
4747
"consider parenthesizing your expression",
4848
sugg,
4949
appl,

tests/ui/precedence.stderr

+11-11
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
error: operator precedence can trip the unwary
1+
error: operator precedence might not be obvious
22
--> tests/ui/precedence.rs:16:5
33
|
44
LL | 1 << 2 + 3;
@@ -7,61 +7,61 @@ LL | 1 << 2 + 3;
77
= note: `-D clippy::precedence` implied by `-D warnings`
88
= help: to override `-D warnings` add `#[allow(clippy::precedence)]`
99

10-
error: operator precedence can trip the unwary
10+
error: operator precedence might not be obvious
1111
--> tests/ui/precedence.rs:17:5
1212
|
1313
LL | 1 + 2 << 3;
1414
| ^^^^^^^^^^ help: consider parenthesizing your expression: `(1 + 2) << 3`
1515

16-
error: operator precedence can trip the unwary
16+
error: operator precedence might not be obvious
1717
--> tests/ui/precedence.rs:18:5
1818
|
1919
LL | 4 >> 1 + 1;
2020
| ^^^^^^^^^^ help: consider parenthesizing your expression: `4 >> (1 + 1)`
2121

22-
error: operator precedence can trip the unwary
22+
error: operator precedence might not be obvious
2323
--> tests/ui/precedence.rs:19:5
2424
|
2525
LL | 1 + 3 >> 2;
2626
| ^^^^^^^^^^ help: consider parenthesizing your expression: `(1 + 3) >> 2`
2727

28-
error: operator precedence can trip the unwary
28+
error: operator precedence might not be obvious
2929
--> tests/ui/precedence.rs:20:5
3030
|
3131
LL | 1 ^ 1 - 1;
3232
| ^^^^^^^^^ help: consider parenthesizing your expression: `1 ^ (1 - 1)`
3333

34-
error: operator precedence can trip the unwary
34+
error: operator precedence might not be obvious
3535
--> tests/ui/precedence.rs:21:5
3636
|
3737
LL | 3 | 2 - 1;
3838
| ^^^^^^^^^ help: consider parenthesizing your expression: `3 | (2 - 1)`
3939

40-
error: operator precedence can trip the unwary
40+
error: operator precedence might not be obvious
4141
--> tests/ui/precedence.rs:22:5
4242
|
4343
LL | 3 & 5 - 2;
4444
| ^^^^^^^^^ help: consider parenthesizing your expression: `3 & (5 - 2)`
4545

46-
error: operator precedence can trip the unwary
46+
error: operator precedence might not be obvious
4747
--> tests/ui/precedence.rs:23:5
4848
|
4949
LL | 0x0F00 & 0x00F0 << 4;
5050
| ^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `0x0F00 & (0x00F0 << 4)`
5151

52-
error: operator precedence can trip the unwary
52+
error: operator precedence might not be obvious
5353
--> tests/ui/precedence.rs:24:5
5454
|
5555
LL | 0x0F00 & 0xF000 >> 4;
5656
| ^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `0x0F00 & (0xF000 >> 4)`
5757

58-
error: operator precedence can trip the unwary
58+
error: operator precedence might not be obvious
5959
--> tests/ui/precedence.rs:25:5
6060
|
6161
LL | 0x0F00 << 1 ^ 3;
6262
| ^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `(0x0F00 << 1) ^ 3`
6363

64-
error: operator precedence can trip the unwary
64+
error: operator precedence might not be obvious
6565
--> tests/ui/precedence.rs:26:5
6666
|
6767
LL | 0x0F00 << 1 | 2;

0 commit comments

Comments
 (0)