Skip to content
This repository was archived by the owner on Nov 21, 2018. It is now read-only.

Enable LLVM assertions on more buildbots #120

Closed
retep998 opened this issue Aug 25, 2016 · 4 comments
Closed

Enable LLVM assertions on more buildbots #120

retep998 opened this issue Aug 25, 2016 · 4 comments

Comments

@retep998
Copy link

A regression recently popped up which apparently would have been caught if the buildbots actually had LLVM assertions enabled rust-lang/rust#35991 (comment)

@TimNN
Copy link
Contributor

TimNN commented Aug 25, 2016

cc rust-lang/rust#35998.

@alexcrichton
Copy link
Contributor

@brson we already enable debug assertions on all bots, do you have any objections to just always enabling llvm assertions on all bots?

@brson
Copy link
Contributor

brson commented Aug 29, 2016

@alexcrichton llvm assertions have a significant compile-time performance penalty. I don't personally mind taking that hit but it will slow down landing velocity.

@brson
Copy link
Contributor

brson commented Aug 29, 2016

Also, not on the dist bots please.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants