Skip to content

One Year Of Rust post features wrong image. #578

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
XAMPPRocky opened this issue May 4, 2020 · 4 comments · Fixed by #597
Closed

One Year Of Rust post features wrong image. #578

XAMPPRocky opened this issue May 4, 2020 · 4 comments · Fixed by #597
Labels
bug content An issue related to an article. help wanted

Comments

@XAMPPRocky
Copy link
Member

The One year of Rust linked to an image (http://rustcamp.com/images/after/cupcakes.jpg) from an expired domain.

Screenshot 2020-05-04 at 17 10 28
@XAMPPRocky XAMPPRocky added bug content An issue related to an article. labels May 4, 2020
@bjorn3
Copy link
Member

bjorn3 commented May 4, 2020

The original: https://web.archive.org/web/20170628094740/http://rustcamp.com/images/after/cupcakes.jpg

@XAMPPRocky
Copy link
Member Author

If anyone is interested I would accept a PR that adds that image to the repository and replaces the link.

@dtolnay
Copy link
Member

dtolnay commented May 4, 2020

It would be good to scrub all the posts of hotlinked images, even if they are not currently broken.

@XAMPPRocky XAMPPRocky mentioned this issue May 4, 2020
Closed
2 tasks
@XAMPPRocky
Copy link
Member Author

@dtolnay Good point! I made a seperate issue to track that.

@Kestrer Kestrer mentioned this issue May 18, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug content An issue related to an article. help wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make all hotlinked images local
3 participants
@dtolnay @XAMPPRocky @bjorn3