From 0e9a13e303a53aa09bb7f71fa615917262b14cc0 Mon Sep 17 00:00:00 2001 From: Jiahao XU <30436523+NobodyXu@users.noreply.github.com> Date: Sat, 19 Oct 2024 18:44:51 +1100 Subject: [PATCH 1/2] Add comment explaining why cc does not rebuild on env PATH change --- src/lib.rs | 1 + 1 file changed, 1 insertion(+) diff --git a/src/lib.rs b/src/lib.rs index dee607ca..fc217512 100644 --- a/src/lib.rs +++ b/src/lib.rs @@ -3736,6 +3736,7 @@ impl Build { if let Some(val) = self.env_cache.read().unwrap().get(v).cloned() { return val; } + // Prevents spurious rebuilds on Windows #1215 if self.emit_rerun_if_env_changed && !provided_by_cargo(v) && v != "PATH" { self.cargo_output .print_metadata(&format_args!("cargo:rerun-if-env-changed={}", v)); From 51b9ad2fa11cd8e552527b1575e36aad9e8fb808 Mon Sep 17 00:00:00 2001 From: Jiahao XU <30436523+NobodyXu@users.noreply.github.com> Date: Sat, 19 Oct 2024 18:50:37 +1100 Subject: [PATCH 2/2] Update src/lib.rs Co-authored-by: Ralf Jung --- src/lib.rs | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/lib.rs b/src/lib.rs index fc217512..a7c44420 100644 --- a/src/lib.rs +++ b/src/lib.rs @@ -3736,7 +3736,8 @@ impl Build { if let Some(val) = self.env_cache.read().unwrap().get(v).cloned() { return val; } - // Prevents spurious rebuilds on Windows #1215 + // Excluding `PATH` prevents spurious rebuilds on Windows, see + // for details. if self.emit_rerun_if_env_changed && !provided_by_cargo(v) && v != "PATH" { self.cargo_output .print_metadata(&format_args!("cargo:rerun-if-env-changed={}", v));