-
Notifications
You must be signed in to change notification settings - Fork 642
/
Copy pathowners.rs
1235 lines (1056 loc) · 44.6 KB
/
owners.rs
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
use crate::{
add_team_to_crate,
builders::{CrateBuilder, PublishBuilder},
new_team,
util::{MockAnonymousUser, MockCookieUser, MockTokenUser, RequestHelper, Response},
TestApp,
};
use crates_io::{
models::Crate,
views::{
EncodableCrateOwnerInvitation, EncodableCrateOwnerInvitationV1, EncodableOwner,
EncodablePublicUser, InvitationResponse,
},
Emails,
};
use chrono::{Duration, Utc};
use crates_io::models::token::{CrateScope, EndpointScope};
use diesel::prelude::*;
use http::StatusCode;
#[derive(Deserialize)]
struct TeamResponse {
teams: Vec<EncodableOwner>,
}
#[derive(Deserialize)]
struct UserResponse {
users: Vec<EncodableOwner>,
}
#[derive(Deserialize, Debug, PartialEq, Eq)]
struct InvitationListResponse {
crate_owner_invitations: Vec<EncodableCrateOwnerInvitationV1>,
users: Vec<EncodablePublicUser>,
}
#[derive(Deserialize, Debug, PartialEq, Eq)]
struct CrateOwnerInvitationsResponse {
invitations: Vec<EncodableCrateOwnerInvitation>,
users: Vec<EncodablePublicUser>,
meta: CrateOwnerInvitationsMeta,
}
#[derive(Deserialize, Debug, PartialEq, Eq)]
struct CrateOwnerInvitationsMeta {
next_page: Option<String>,
}
// Implementing locally for now, unless these are needed elsewhere
impl MockCookieUser {
fn try_accept_ownership_invitation<T: serde::de::DeserializeOwned>(
&self,
krate_name: &str,
krate_id: i32,
) -> Response<T> {
let body = json!({
"crate_owner_invite": {
"invited_by_username": "",
"crate_name": krate_name,
"crate_id": krate_id,
"created_at": "",
"accepted": true
}
});
let url = format!("/api/v1/me/crate_owner_invitations/{krate_id}");
self.put(&url, body.to_string().as_bytes())
}
/// As the currently logged in user, accept an invitation to become an owner of the named
/// crate.
fn accept_ownership_invitation(&self, krate_name: &str, krate_id: i32) {
#[derive(Deserialize)]
struct CrateOwnerInvitation {
crate_owner_invitation: InvitationResponse,
}
let crate_owner_invite: CrateOwnerInvitation = self
.try_accept_ownership_invitation(krate_name, krate_id)
.good();
assert!(crate_owner_invite.crate_owner_invitation.accepted);
assert_eq!(crate_owner_invite.crate_owner_invitation.crate_id, krate_id);
}
/// As the currently logged in user, decline an invitation to become an owner of the named
/// crate.
fn decline_ownership_invitation(&self, krate_name: &str, krate_id: i32) {
let body = json!({
"crate_owner_invite": {
"invited_by_username": "",
"crate_name": krate_name,
"crate_id": krate_id,
"created_at": "",
"accepted": false
}
});
#[derive(Deserialize)]
struct CrateOwnerInvitation {
crate_owner_invitation: InvitationResponse,
}
let url = format!("/api/v1/me/crate_owner_invitations/{krate_id}");
let crate_owner_invite: CrateOwnerInvitation =
self.put(&url, body.to_string().as_bytes()).good();
assert!(!crate_owner_invite.crate_owner_invitation.accepted);
assert_eq!(crate_owner_invite.crate_owner_invitation.crate_id, krate_id);
}
/// As the currently logged in user, list my pending invitations.
fn list_invitations(&self) -> InvitationListResponse {
self.get("/api/v1/me/crate_owner_invitations").good()
}
}
impl MockAnonymousUser {
fn accept_ownership_invitation_by_token(&self, token: &str) {
#[derive(Deserialize)]
struct Response {
crate_owner_invitation: InvitationResponse,
}
let response: Response = self.try_accept_ownership_invitation_by_token(token).good();
assert!(response.crate_owner_invitation.accepted);
}
fn try_accept_ownership_invitation_by_token<T: serde::de::DeserializeOwned>(
&self,
token: &str,
) -> Response<T> {
let url = format!("/api/v1/me/crate_owner_invitations/accept/{token}");
self.put(&url, &[])
}
}
#[test]
fn new_crate_owner() {
let (app, _, _, token) = TestApp::full().with_token();
// Create a crate under one user
let crate_to_publish = PublishBuilder::new("foo_owner", "1.0.0");
token.publish_crate(crate_to_publish).good();
// Add the second user as an owner (with a different case to make sure that works)
let user2 = app.db_new_user("Bar");
token.add_user_owner("foo_owner", "BAR");
// accept invitation for user to be added as owner
let krate: Crate = app.db(|conn| Crate::by_name("foo_owner").first(conn).unwrap());
user2.accept_ownership_invitation("foo_owner", krate.id);
// Make sure this shows up as one of their crates.
let crates = user2.search_by_user_id(user2.as_model().id);
assert_eq!(crates.crates.len(), 1);
// And upload a new version as the second user
let crate_to_publish = PublishBuilder::new("foo_owner", "2.0.0");
user2
.db_new_token("bar_token")
.publish_crate(crate_to_publish)
.good();
}
fn create_and_add_owner(
app: &TestApp,
token: &MockTokenUser,
username: &str,
krate: &Crate,
) -> MockCookieUser {
let user = app.db_new_user(username);
token.add_user_owner(&krate.name, username);
user.accept_ownership_invitation(&krate.name, krate.id);
user
}
/// Ensures that so long as at least one owner remains associated with the crate,
/// a user can still remove their own login as an owner
#[test]
fn owners_can_remove_self() {
let (app, _, user, token) = TestApp::init().with_token();
let username = &user.as_model().gh_login;
let krate = app
.db(|conn| CrateBuilder::new("owners_selfremove", user.as_model().id).expect_build(conn));
// Deleting yourself when you're the only owner isn't allowed.
let response = token.remove_named_owner("owners_selfremove", username);
assert_eq!(response.status(), StatusCode::OK);
assert_eq!(
response.into_json(),
json!({ "errors": [{ "detail": "cannot remove all individual owners of a crate. Team member don't have permission to modify owners, so at least one individual owner is required." }] })
);
create_and_add_owner(&app, &token, "secondowner", &krate);
// Deleting yourself when there are other owners is allowed.
let response = token.remove_named_owner("owners_selfremove", username);
assert_eq!(response.status(), StatusCode::OK);
assert_eq!(
response.into_json(),
json!({ "msg": "owners successfully removed", "ok": true })
);
// After you delete yourself, you no longer have permissions to manage the crate.
let response = token.remove_named_owner("owners_selfremove", username);
assert_eq!(response.status(), StatusCode::OK);
assert_eq!(
response.into_json(),
json!({ "errors": [{ "detail": "only owners have permission to modify owners" }] })
);
}
/// Verify consistency when adidng or removing multiple owners in a single request.
#[test]
fn modify_multiple_owners() {
let (app, _, user, token) = TestApp::init().with_token();
let username = &user.as_model().gh_login;
let krate =
app.db(|conn| CrateBuilder::new("owners_multiple", user.as_model().id).expect_build(conn));
let user2 = create_and_add_owner(&app, &token, "user2", &krate);
let user3 = create_and_add_owner(&app, &token, "user3", &krate);
// Deleting all owners is not allowed.
let response = token.remove_named_owners("owners_multiple", &[username, "user2", "user3"]);
assert_eq!(response.status(), StatusCode::OK);
assert_eq!(
response.into_json(),
json!({ "errors": [{ "detail": "cannot remove all individual owners of a crate. Team member don't have permission to modify owners, so at least one individual owner is required." }] })
);
assert_eq!(app.db(|conn| krate.owners(conn).unwrap()).len(), 3);
// Deleting two owners at once is allowed.
let response = token.remove_named_owners("owners_multiple", &["user2", "user3"]);
assert_eq!(response.status(), StatusCode::OK);
assert_eq!(
response.into_json(),
json!({ "msg": "owners successfully removed", "ok": true })
);
assert_eq!(app.db(|conn| krate.owners(conn).unwrap()).len(), 1);
// Adding multiple users fails if one of them already is an owner.
let response = token.add_named_owners("owners_multiple", &["user2", username]);
assert_eq!(response.status(), StatusCode::OK);
assert_eq!(
response.into_json(),
json!({ "errors": [{ "detail": "`foo` is already an owner" }] })
);
assert_eq!(app.db(|conn| krate.owners(conn).unwrap()).len(), 1);
// Adding multiple users at once succeeds.
let response = token.add_named_owners("owners_multiple", &["user2", "user3"]);
assert_eq!(response.status(), StatusCode::OK);
assert_eq!(
response.into_json(),
json!({
"msg": "user user2 has been invited to be an owner of crate owners_multiple,user user3 has been invited to be an owner of crate owners_multiple",
"ok": true,
})
);
user2.accept_ownership_invitation(&krate.name, krate.id);
user3.accept_ownership_invitation(&krate.name, krate.id);
assert_eq!(app.db(|conn| krate.owners(conn).unwrap()).len(), 3);
}
#[test]
fn owner_change_via_cookie() {
let (app, _, cookie) = TestApp::full().with_user();
let user2 = app.db_new_user("user-2");
let user2 = user2.as_model();
let krate =
app.db(|conn| CrateBuilder::new("foo_crate", cookie.as_model().id).expect_build(conn));
let url = format!("/api/v1/crates/{}/owners", krate.name);
let body = json!({ "owners": [user2.gh_login] });
let body = serde_json::to_vec(&body).unwrap();
let response = cookie.put::<()>(&url, &body);
assert_eq!(response.status(), StatusCode::OK);
assert_eq!(
response.into_json(),
json!({ "ok": true, "msg": "user user-2 has been invited to be an owner of crate foo_crate" })
);
}
#[test]
fn owner_change_via_token() {
let (app, _, _, token) = TestApp::full().with_token();
let user2 = app.db_new_user("user-2");
let user2 = user2.as_model();
let krate =
app.db(|conn| CrateBuilder::new("foo_crate", token.as_model().user_id).expect_build(conn));
let url = format!("/api/v1/crates/{}/owners", krate.name);
let body = json!({ "owners": [user2.gh_login] });
let body = serde_json::to_vec(&body).unwrap();
let response = token.put::<()>(&url, &body);
assert_eq!(response.status(), StatusCode::OK);
assert_eq!(
response.into_json(),
json!({ "ok": true, "msg": "user user-2 has been invited to be an owner of crate foo_crate" })
);
}
#[test]
fn owner_change_via_change_owner_token() {
let (app, _, _, token) =
TestApp::full().with_scoped_token(None, Some(vec![EndpointScope::ChangeOwners]));
let user2 = app.db_new_user("user-2");
let user2 = user2.as_model();
let krate =
app.db(|conn| CrateBuilder::new("foo_crate", token.as_model().user_id).expect_build(conn));
let url = format!("/api/v1/crates/{}/owners", krate.name);
let body = json!({ "owners": [user2.gh_login] });
let body = serde_json::to_vec(&body).unwrap();
let response = token.put::<()>(&url, &body);
assert_eq!(response.status(), StatusCode::OK);
assert_eq!(
response.into_json(),
json!({ "ok": true, "msg": "user user-2 has been invited to be an owner of crate foo_crate" })
);
}
#[test]
fn owner_change_via_change_owner_token_with_matching_crate_scope() {
let crate_scopes = Some(vec![CrateScope::try_from("foo_crate").unwrap()]);
let endpoint_scopes = Some(vec![EndpointScope::ChangeOwners]);
let (app, _, _, token) = TestApp::full().with_scoped_token(crate_scopes, endpoint_scopes);
let user2 = app.db_new_user("user-2");
let user2 = user2.as_model();
let krate =
app.db(|conn| CrateBuilder::new("foo_crate", token.as_model().user_id).expect_build(conn));
let url = format!("/api/v1/crates/{}/owners", krate.name);
let body = json!({ "owners": [user2.gh_login] });
let body = serde_json::to_vec(&body).unwrap();
let response = token.put::<()>(&url, &body);
assert_eq!(response.status(), StatusCode::OK);
assert_eq!(
response.into_json(),
json!({ "ok": true, "msg": "user user-2 has been invited to be an owner of crate foo_crate" })
);
}
#[test]
fn owner_change_via_change_owner_token_with_wrong_crate_scope() {
let crate_scopes = Some(vec![CrateScope::try_from("bar").unwrap()]);
let endpoint_scopes = Some(vec![EndpointScope::ChangeOwners]);
let (app, _, _, token) = TestApp::full().with_scoped_token(crate_scopes, endpoint_scopes);
let user2 = app.db_new_user("user-2");
let user2 = user2.as_model();
let krate =
app.db(|conn| CrateBuilder::new("foo_crate", token.as_model().user_id).expect_build(conn));
let url = format!("/api/v1/crates/{}/owners", krate.name);
let body = json!({ "owners": [user2.gh_login] });
let body = serde_json::to_vec(&body).unwrap();
let response = token.put::<()>(&url, &body);
assert_eq!(response.status(), StatusCode::FORBIDDEN);
assert_eq!(
response.into_json(),
json!({ "errors": [{ "detail": "must be logged in to perform that action" }] })
);
}
#[test]
fn owner_change_via_publish_token() {
let (app, _, _, token) =
TestApp::full().with_scoped_token(None, Some(vec![EndpointScope::PublishUpdate]));
let user2 = app.db_new_user("user-2");
let user2 = user2.as_model();
let krate =
app.db(|conn| CrateBuilder::new("foo_crate", token.as_model().user_id).expect_build(conn));
let url = format!("/api/v1/crates/{}/owners", krate.name);
let body = json!({ "owners": [user2.gh_login] });
let body = serde_json::to_vec(&body).unwrap();
let response = token.put::<()>(&url, &body);
assert_eq!(response.status(), StatusCode::FORBIDDEN);
assert_eq!(
response.into_json(),
json!({ "errors": [{ "detail": "must be logged in to perform that action" }] })
);
}
#[test]
fn owner_change_without_auth() {
let (app, anon, cookie) = TestApp::full().with_user();
let user2 = app.db_new_user("user-2");
let user2 = user2.as_model();
let krate =
app.db(|conn| CrateBuilder::new("foo_crate", cookie.as_model().id).expect_build(conn));
let url = format!("/api/v1/crates/{}/owners", krate.name);
let body = json!({ "owners": [user2.gh_login] });
let body = serde_json::to_vec(&body).unwrap();
let response = anon.put::<()>(&url, &body);
assert_eq!(response.status(), StatusCode::FORBIDDEN);
assert_eq!(
response.into_json(),
json!({ "errors": [{ "detail": "must be logged in to perform that action" }] })
);
}
#[test]
fn invite_already_invited_user() {
let (app, _, _, owner) = TestApp::init().with_token();
app.db_new_user("invited_user");
app.db(|conn| CrateBuilder::new("crate_name", owner.as_model().user_id).expect_build(conn));
// Ensure no emails were sent up to this point
assert_eq!(0, app.as_inner().emails.mails_in_memory().unwrap().len());
// Invite the user the first time
let response = owner.add_named_owner("crate_name", "invited_user");
assert_eq!(response.status(), StatusCode::OK);
assert_eq!(
response.into_json(),
json!({
"msg": "user invited_user has been invited to be an owner of crate crate_name",
"ok": true,
})
);
// Check one email was sent, this will be the ownership invite email
assert_eq!(1, app.as_inner().emails.mails_in_memory().unwrap().len());
// Then invite the user a second time, the message should point out the user is already invited
let response = owner.add_named_owner("crate_name", "invited_user");
assert_eq!(response.status(), StatusCode::OK);
assert_eq!(
response.into_json(),
json!({
"msg": "user invited_user already has a pending invitation to be an owner of crate crate_name",
"ok": true,
})
);
// Check that no new email is sent after the second invitation
assert_eq!(1, app.as_inner().emails.mails_in_memory().unwrap().len());
}
#[test]
fn invite_with_existing_expired_invite() {
let (app, _, _, owner) = TestApp::init().with_token();
app.db_new_user("invited_user");
let krate =
app.db(|conn| CrateBuilder::new("crate_name", owner.as_model().user_id).expect_build(conn));
// Ensure no emails were sent up to this point
assert_eq!(0, app.as_inner().emails.mails_in_memory().unwrap().len());
// Invite the user the first time
let response = owner.add_named_owner("crate_name", "invited_user");
assert_eq!(response.status(), StatusCode::OK);
assert_eq!(
response.into_json(),
json!({
"msg": "user invited_user has been invited to be an owner of crate crate_name",
"ok": true,
})
);
// Check one email was sent, this will be the ownership invite email
assert_eq!(1, app.as_inner().emails.mails_in_memory().unwrap().len());
// Simulate the previous invite expiring
expire_invitation(&app, krate.id);
// Then invite the user a second time, a new invite is created as the old one expired
let response = owner.add_named_owner("crate_name", "invited_user");
assert_eq!(response.status(), StatusCode::OK);
assert_eq!(
response.into_json(),
json!({
"msg": "user invited_user has been invited to be an owner of crate crate_name",
"ok": true,
})
);
// Check that the email for the second invite was sent
assert_eq!(2, app.as_inner().emails.mails_in_memory().unwrap().len());
}
/// Testing the crate ownership between two crates and one team.
/// Given two crates, one crate owned by both a team and a user,
/// one only owned by a user, check that the CrateList returned
/// for the user_id contains only the crates owned by that user,
/// and that the CrateList returned for the team_id contains
/// only crates owned by that team.
#[test]
fn check_ownership_two_crates() {
let (app, anon, user) = TestApp::init().with_user();
let user = user.as_model();
let (krate_owned_by_team, team) = app.db(|conn| {
let t = new_team("team_foo").create_or_update(conn).unwrap();
let krate = CrateBuilder::new("foo", user.id).expect_build(conn);
add_team_to_crate(&t, &krate, user, conn).unwrap();
(krate, t)
});
let user2 = app.db_new_user("user_bar");
let user2 = user2.as_model();
let krate_not_owned_by_team =
app.db(|conn| CrateBuilder::new("bar", user2.id).expect_build(conn));
let json = anon.search_by_user_id(user2.id);
assert_eq!(json.crates[0].name, krate_not_owned_by_team.name);
assert_eq!(json.crates.len(), 1);
let query = format!("team_id={}", team.id);
let json = anon.search(&query);
assert_eq!(json.crates.len(), 1);
assert_eq!(json.crates[0].name, krate_owned_by_team.name);
}
/// Given a crate owned by both a team and a user, check that the
/// JSON returned by the /owner_team route and /owner_user route
/// contains the correct kind of owner
///
/// Note that in this case function new_team must take a team name
/// of form github:org_name:team_name as that is the format
/// EncodableOwner::encodable is expecting
#[test]
fn check_ownership_one_crate() {
let (app, anon, user) = TestApp::init().with_user();
let user = user.as_model();
let team = app.db(|conn| {
let t = new_team("github:test_org:team_sloth")
.create_or_update(conn)
.unwrap();
let krate = CrateBuilder::new("best_crate", user.id).expect_build(conn);
add_team_to_crate(&t, &krate, user, conn).unwrap();
t
});
let json: TeamResponse = anon.get("/api/v1/crates/best_crate/owner_team").good();
assert_eq!(json.teams[0].kind, "team");
assert_eq!(json.teams[0].name, team.name);
let json: UserResponse = anon.get("/api/v1/crates/best_crate/owner_user").good();
assert_eq!(json.users[0].kind, "user");
assert_eq!(json.users[0].name, user.name);
}
#[test]
fn deleted_ownership_isnt_in_owner_user() {
let (app, anon, user) = TestApp::init().with_user();
let user = user.as_model();
app.db(|conn| {
let krate = CrateBuilder::new("foo_my_packages", user.id).expect_build(conn);
krate.owner_remove(conn, &user.gh_login).unwrap();
});
let json: UserResponse = anon.get("/api/v1/crates/foo_my_packages/owner_user").good();
assert_eq!(json.users.len(), 0);
}
#[test]
fn invitations_are_empty_by_default_v1() {
let (_, _, user) = TestApp::init().with_user();
let json = user.list_invitations();
assert_eq!(json.crate_owner_invitations.len(), 0);
}
#[test]
fn api_token_cannot_list_invitations_v1() {
let (_, _, _, token) = TestApp::init().with_token();
token
.get("/api/v1/me/crate_owner_invitations")
.assert_forbidden();
}
#[test]
fn invitations_list_v1() {
let (app, _, owner, token) = TestApp::init().with_token();
let owner = owner.as_model();
let krate = app.db(|conn| CrateBuilder::new("invited_crate", owner.id).expect_build(conn));
let user = app.db_new_user("invited_user");
token.add_user_owner("invited_crate", "invited_user");
let response = user.get::<()>("/api/v1/me/crate_owner_invitations");
assert_eq!(response.status(), StatusCode::OK);
let invitations = user.list_invitations();
assert_eq!(
invitations,
InvitationListResponse {
crate_owner_invitations: vec![EncodableCrateOwnerInvitationV1 {
crate_id: krate.id,
crate_name: krate.name,
invited_by_username: owner.gh_login.clone(),
invitee_id: user.as_model().id,
inviter_id: owner.id,
// This value changes with each test run so we can't use a fixed value here
created_at: invitations.crate_owner_invitations[0].created_at,
// This value changes with each test run so we can't use a fixed value here
expires_at: invitations.crate_owner_invitations[0].expires_at,
}],
users: vec![owner.clone().into(), user.as_model().clone().into()],
}
);
}
#[test]
fn invitations_list_does_not_include_expired_invites_v1() {
let (app, _, owner, token) = TestApp::init().with_token();
let owner = owner.as_model();
let user = app.db_new_user("invited_user");
let krate1 = app.db(|conn| CrateBuilder::new("invited_crate_1", owner.id).expect_build(conn));
let krate2 = app.db(|conn| CrateBuilder::new("invited_crate_2", owner.id).expect_build(conn));
token.add_user_owner("invited_crate_1", "invited_user");
token.add_user_owner("invited_crate_2", "invited_user");
// Simulate one of the invitations expiring
expire_invitation(&app, krate1.id);
let invitations = user.list_invitations();
assert_eq!(
invitations,
InvitationListResponse {
crate_owner_invitations: vec![EncodableCrateOwnerInvitationV1 {
crate_id: krate2.id,
crate_name: krate2.name,
invited_by_username: owner.gh_login.clone(),
invitee_id: user.as_model().id,
inviter_id: owner.id,
// This value changes with each test run so we can't use a fixed value here
created_at: invitations.crate_owner_invitations[0].created_at,
// This value changes with each test run so we can't use a fixed value here
expires_at: invitations.crate_owner_invitations[0].expires_at,
}],
users: vec![owner.clone().into(), user.as_model().clone().into()],
}
);
}
/// Given a user inviting a different user to be a crate
/// owner, check that the user invited can accept their
/// invitation, the invitation will be deleted from
/// the invitations table, and a new crate owner will be
/// inserted into the table for the given crate.
#[test]
fn test_accept_invitation() {
let (app, anon, owner, owner_token) = TestApp::init().with_token();
let owner = owner.as_model();
let invited_user = app.db_new_user("user_bar");
let krate = app.db(|conn| CrateBuilder::new("accept_invitation", owner.id).expect_build(conn));
// Invite a new owner
owner_token.add_user_owner("accept_invitation", "user_bar");
// New owner accepts the invitation
invited_user.accept_ownership_invitation(&krate.name, krate.id);
// New owner's invitation list should now be empty
let json = invited_user.list_invitations();
assert_eq!(json.crate_owner_invitations.len(), 0);
// New owner is now listed as an owner, so the crate has two owners
let json = anon.show_crate_owners("accept_invitation");
assert_eq!(json.users.len(), 2);
}
/// Given a user inviting a different user to be a crate
/// owner, check that the user invited can decline their
/// invitation and the invitation will be deleted from
/// the invitations table.
#[test]
fn test_decline_invitation() {
let (app, anon, owner, owner_token) = TestApp::init().with_token();
let owner = owner.as_model();
let invited_user = app.db_new_user("user_bar");
let krate = app.db(|conn| CrateBuilder::new("decline_invitation", owner.id).expect_build(conn));
// Invite a new owner
owner_token.add_user_owner("decline_invitation", "user_bar");
// Invited user declines the invitation
invited_user.decline_ownership_invitation(&krate.name, krate.id);
// Invited user's invitation list should now be empty
let json = invited_user.list_invitations();
assert_eq!(json.crate_owner_invitations.len(), 0);
// Invited user is NOT listed as an owner, so the crate still only has one owner
let json = anon.show_crate_owners("decline_invitation");
assert_eq!(json.users.len(), 1);
}
#[test]
fn test_accept_invitation_by_mail() {
let (app, anon, owner, owner_token) = TestApp::init().with_token();
let owner = owner.as_model();
let invited_user = app.db_new_user("user_bar");
let _krate = app.db(|conn| CrateBuilder::new("accept_invitation", owner.id).expect_build(conn));
// Invite a new owner
owner_token.add_user_owner("accept_invitation", "user_bar");
// Retrieve the ownership invitation
let invite_token = extract_token_from_invite_email(&app.as_inner().emails);
// Accept the invitation anonymously with a token
anon.accept_ownership_invitation_by_token(&invite_token);
// New owner's invitation list should now be empty
let json = invited_user.list_invitations();
assert_eq!(json.crate_owner_invitations.len(), 0);
// New owner is now listed as an owner, so the crate has two owners
let json = anon.show_crate_owners("accept_invitation");
assert_eq!(json.users.len(), 2);
}
//// Hacky way to simulate the expiration of an ownership invitation. Instead of letting a month
//// pass, the creation date of the invite is moved back a month.
fn expire_invitation(app: &TestApp, crate_id: i32) {
use crates_io::schema::crate_owner_invitations;
app.db(|conn| {
let expiration = app.as_inner().config.ownership_invitations_expiration_days as i64;
let created_at = (Utc::now() - Duration::days(expiration)).naive_utc();
diesel::update(crate_owner_invitations::table)
.set(crate_owner_invitations::created_at.eq(created_at))
.filter(crate_owner_invitations::crate_id.eq(crate_id))
.execute(conn)
.expect("failed to override the creation time");
});
}
#[test]
fn test_accept_expired_invitation() {
let (app, anon, owner, owner_token) = TestApp::init().with_token();
let owner = owner.as_model();
let invited_user = app.db_new_user("demo_user");
let krate = app.db(|conn| CrateBuilder::new("demo_crate", owner.id).expect_build(conn));
// Invite a new user
owner_token.add_user_owner("demo_crate", "demo_user");
// Manually update the creation time to simulate the invite expiring
expire_invitation(&app, krate.id);
// New owner tries to accept the invitation but it fails
let resp = invited_user.try_accept_ownership_invitation::<()>(&krate.name, krate.id);
assert_eq!(StatusCode::GONE, resp.status());
assert_eq!(
json!({
"errors": [
{
"detail": "The invitation to become an owner of the demo_crate crate expired. \
Please reach out to an owner of the crate to request a new invitation.",
}
]
}),
resp.into_json()
);
// Invited user is NOT listed as an owner, so the crate still only has one owner
let json = anon.show_crate_owners("demo_crate");
assert_eq!(json.users.len(), 1);
}
#[test]
fn test_decline_expired_invitation() {
let (app, anon, owner, owner_token) = TestApp::init().with_token();
let owner = owner.as_model();
let invited_user = app.db_new_user("demo_user");
let krate = app.db(|conn| CrateBuilder::new("demo_crate", owner.id).expect_build(conn));
// Invite a new user
owner_token.add_user_owner("demo_crate", "demo_user");
// Manually update the creation time to simulate the invite expiring
expire_invitation(&app, krate.id);
// New owner declines the invitation and it succeeds, even though the invitation expired.
invited_user.decline_ownership_invitation(&krate.name, krate.id);
// Invited user is NOT listed as an owner, so the crate still only has one owner
let json = anon.show_crate_owners("demo_crate");
assert_eq!(json.users.len(), 1);
}
#[test]
fn test_accept_expired_invitation_by_mail() {
let (app, anon, owner, owner_token) = TestApp::init().with_token();
let owner = owner.as_model();
let _invited_user = app.db_new_user("demo_user");
let krate = app.db(|conn| CrateBuilder::new("demo_crate", owner.id).expect_build(conn));
// Invite a new owner
owner_token.add_user_owner("demo_crate", "demo_user");
// Manually update the creation time to simulate the invite expiring
expire_invitation(&app, krate.id);
// Retrieve the ownership invitation
let invite_token = extract_token_from_invite_email(&app.as_inner().emails);
// Try to accept the invitation, and ensure it fails.
let resp = anon.try_accept_ownership_invitation_by_token::<()>(&invite_token);
assert_eq!(StatusCode::GONE, resp.status());
assert_eq!(
json!({
"errors": [
{
"detail": "The invitation to become an owner of the demo_crate crate expired. \
Please reach out to an owner of the crate to request a new invitation.",
}
]
}),
resp.into_json()
);
// Invited user is NOT listed as an owner, so the crate still only has one owner
let json = anon.show_crate_owners("demo_crate");
assert_eq!(json.users.len(), 1);
}
#[test]
fn inactive_users_dont_get_invitations() {
use crates_io::models::NewUser;
use std::borrow::Cow;
let (app, _, owner, owner_token) = TestApp::init().with_token();
let owner = owner.as_model();
// An inactive user with gh_id -1 and an active user with a non-negative gh_id both exist
let invited_gh_login = "user_bar";
let krate_name = "inactive_test";
app.db(|conn| {
NewUser {
gh_id: -1,
gh_login: invited_gh_login,
name: None,
gh_avatar: None,
gh_access_token: Cow::Borrowed("some random token"),
}
.create_or_update(None, &app.as_inner().emails, conn)
.unwrap();
CrateBuilder::new(krate_name, owner.id).expect_build(conn);
});
let invited_user = app.db_new_user(invited_gh_login);
owner_token.add_user_owner(krate_name, "user_bar");
let json = invited_user.list_invitations();
assert_eq!(json.crate_owner_invitations.len(), 1);
}
#[test]
fn highest_gh_id_is_most_recent_account_we_know_of() {
let (app, _, owner, owner_token) = TestApp::init().with_token();
let owner = owner.as_model();
// An inactive user with a lower gh_id and an active user with a higher gh_id both exist
let invited_gh_login = "user_bar";
let krate_name = "newer_user_test";
// This user will get a lower gh_id, given how crate::new_user works
app.db_new_user(invited_gh_login);
let invited_user = app.db_new_user(invited_gh_login);
app.db(|conn| {
CrateBuilder::new(krate_name, owner.id).expect_build(conn);
});
owner_token.add_user_owner(krate_name, "user_bar");
let json = invited_user.list_invitations();
assert_eq!(json.crate_owner_invitations.len(), 1);
}
fn extract_token_from_invite_email(emails: &Emails) -> String {
let message = emails
.mails_in_memory()
.unwrap()
.into_iter()
.find(|m| m.subject.contains("invitation"))
.expect("missing email");
// Simple (but kinda fragile) parser to extract the token.
let before_token = "/accept-invite/";
let after_token = " ";
let body = message.body.as_str();
let before_pos = body.find(before_token).unwrap() + before_token.len();
let after_pos = before_pos + body[before_pos..].find(after_token).unwrap();
body[before_pos..after_pos].to_string()
}
//
// Tests for the `GET /api/private/crate-owners-invitations` endpoint
//
#[track_caller]
fn get_invitations(user: &MockCookieUser, query: &str) -> CrateOwnerInvitationsResponse {
user.get_with_query::<CrateOwnerInvitationsResponse>(
"/api/private/crate_owner_invitations",
query,
)
.good()
}
#[test]
fn invitation_list() {
let (app, _, owner, token) = TestApp::init().with_token();
let (crate1, crate2) = app.db(|conn| {
(
CrateBuilder::new("crate_1", owner.as_model().id).expect_build(conn),
CrateBuilder::new("crate_2", owner.as_model().id).expect_build(conn),
)
});
let user1 = app.db_new_user("user_1");
let user2 = app.db_new_user("user_2");
token.add_user_owner("crate_1", "user_1");
token.add_user_owner("crate_1", "user_2");
token.add_user_owner("crate_2", "user_1");
// user1 has invites for both crates
let invitations = get_invitations(&user1, &format!("invitee_id={}", user1.as_model().id));
assert_eq!(
invitations,
CrateOwnerInvitationsResponse {
invitations: vec![
EncodableCrateOwnerInvitation {
crate_id: crate1.id,
crate_name: crate1.name.clone(),
invitee_id: user1.as_model().id,
inviter_id: owner.as_model().id,
// The timestamps depend on when the test is run.
created_at: invitations.invitations[0].created_at,
expires_at: invitations.invitations[0].expires_at,
},
EncodableCrateOwnerInvitation {
crate_id: crate2.id,
crate_name: crate2.name.clone(),
invitee_id: user1.as_model().id,
inviter_id: owner.as_model().id,
// The timestamps depend on when the test is run.
created_at: invitations.invitations[1].created_at,
expires_at: invitations.invitations[1].expires_at,
},
],
users: vec![
owner.as_model().clone().into(),
user1.as_model().clone().into()
],
meta: CrateOwnerInvitationsMeta { next_page: None },
}
);
// user2 is only invited to a single crate
let invitations = get_invitations(&user2, &format!("invitee_id={}", user2.as_model().id));
assert_eq!(
invitations,
CrateOwnerInvitationsResponse {
invitations: vec![EncodableCrateOwnerInvitation {
crate_id: crate1.id,
crate_name: crate1.name.clone(),
invitee_id: user2.as_model().id,
inviter_id: owner.as_model().id,
// The timestamps depend on when the test is run.
created_at: invitations.invitations[0].created_at,
expires_at: invitations.invitations[0].expires_at,
}],
users: vec![
owner.as_model().clone().into(),
user2.as_model().clone().into(),
],