Merge branch 'rust-lang:master' into display-errors-instead-of-logging

Author: byfnoel

Diff for: .cargo/audit.toml

@@ -1,22 +1,15 @@
 [advisories]
 ignore = [
-    "RUSTSEC-2023-0018", # rustwide -> remove_dir_all,TOCTOU / Race Condition 
-    # https://github.com/rust-lang/docs.rs/issues/2074
-
-    "RUSTSEC-2023-0071", # potential key recovery through timing sidechannels
-
-    "RUSTSEC-2024-0013", # Memory corruption, denial of service, and arbitrary code execution in libgit2
-    # https://github.com/rust-lang/docs.rs/issues/2414
+    "RUSTSEC-2023-0071", # rsa: potential key recovery through timing sidechannels
 
     "RUSTSEC-2024-0320", # yaml-rust is unmaintained. 
     # https://github.com/rust-lang/docs.rs/issues/2469
 
-    "RUSTSEC-2024-0363", # sqlx, Binary Protocol Misinterpretation caused by Truncating or Overflowing Cast
-    # https://github.com/rust-lang/docs.rs/issues/2588
-    # SECURITY: 
-    # We have plenty of places where user input ends up in sql, for example the inner doc path for doc pages, crate names etc.
-    # But in all these places, the user content is part of the path of the URL.
-    # Since URL length is limited by cloudfront, and also by nginx, to something much smaller than 4 GiB, I don't think this issue affects us.
+    "RUSTSEC-2024-0370", # proc-macro-error is unmaintained
+    # https://github.com/rust-lang/docs.rs/issues/2595
+
+    "RUSTSEC-2025-0007", # `ring` is unmaintained. Not much we can do about it.
+    # https://github.com/rust-lang/docs.rs/issues/2741
 ]
 informational_warnings = ["unmaintained"] # warn for categories of informational advisories
 severity_threshold = "low" # CVSS severity ("none", "low", "medium", "high", "critical")

Diff for: Cargo.lock

@@ -318,7 +318,7 @@ impl ReleaseType {
         match self {
             Self::Recent => "recent",
             Self::Stars => "stars",
-            Self::RecentFailures => "recent_failures",
+            Self::RecentFailures => "recent-failures",
             Self::Failures => "failures",
             Self::Search => "search",
         }
@@ -2184,4 +2184,69 @@ mod tests {
             Ok(())
         })
     }
+
+    #[test]
+    fn recent_failures_correct_pagination_links() {
+        async_wrapper(|env| async move {
+            for i in 0..RELEASES_IN_RELEASES + 1 {
+                env.fake_release()
+                    .await
+                    .name("failed")
+                    .version(&format!("0.0.{}", i))
+                    .build_result_failed()
+                    .create()
+                    .await?;
+            }
+
+            let web = env.web_app().await;
+
+            let response = web.get("/releases/recent-failures").await?;
+            assert!(response.status().is_success());
+
+            let page = kuchikiki::parse_html().one(response.text().await?);
+            assert_eq!(
+                page.select("div.description")
+                    .unwrap()
+                    .next()
+                    .unwrap()
+                    .text_contents(),
+                "Recent crates failed to build"
+            );
+
+            let next_page_link = page.select("div.pagination > a").unwrap().next().unwrap();
+            assert_eq!(next_page_link.text_contents().trim(), "Next Page");
+
+            let next_page_url = next_page_link
+                .attributes
+                .borrow()
+                .get("href")
+                .unwrap()
+                .to_owned();
+            assert_eq!(next_page_url, "/releases/recent-failures/2");
+
+            let response = web.get(&next_page_url).await?;
+            assert!(response.status().is_success());
+
+            let page = kuchikiki::parse_html().one(response.text().await?);
+            assert_eq!(
+                page.select("div.description")
+                    .unwrap()
+                    .next()
+                    .unwrap()
+                    .text_contents(),
+                "Recent crates failed to build"
+            );
+            assert_eq!(
+                page.select(".recent-releases-container > ul > li .name")
+                    .unwrap()
+                    .next()
+                    .unwrap()
+                    .text_contents()
+                    .trim(),
+                "failed-0.0.0"
+            );
+
+            Ok(())
+        });
+    }
 }

Diff for: src/web/releases.rs

@@ -27,6 +27,11 @@ <h1>Shorthand URLs</h1>
                     <td>Latest version of clap</td>
                 </tr>
 
+                <tr>
+                    <td><a href="https://docs.rs/clap::Command">docs.rs/clap::Command</a></td>
+                    <td>Latest version of clap, and search for "Command" within the crate</td>
+                </tr>
+
                 <tr>
                     <td>
                         <a href="https://docs.rs/clap/%7E2">docs.rs/clap/~2</a>