Skip to content

dyn could be explained better #374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
knocte opened this issue Jul 10, 2019 · 5 comments
Closed

dyn could be explained better #374

knocte opened this issue Jul 10, 2019 · 5 comments

Comments

@knocte
Copy link

knocte commented Jul 10, 2019

There are two issues with this page: https://doc.rust-lang.org/edition-guide/rust-2018/trait-system/dyn-trait-for-trait-objects.html

  1. It doesn't explain where does "dyn" come from, is it from the word "dynamic"? It should mention dynamic dispatching AFAIU.
  2. It's targeted to people that are already familiar with Rust (that is, the people that were already using Rust before dyn keyword existed). If a new developer comes, it's better to just talk about the new way of doing things, not just mentioning that dyn is some new way to do some old stuff.
@pietroalbini
Copy link
Member

Thanks for reporting this! Edition guide issues are tracked in its repo though, could you file the issue there?

@knocte
Copy link
Author

knocte commented Jul 10, 2019

Thanks, opened rust-lang/edition-guide#183

@knocte
Copy link
Author

knocte commented Jul 10, 2019

@pietroalbini looks like the bullet (2) of my list doesn't apply to editions. We should reopen this issue to have a non-edition docs about dyn.

@pietroalbini
Copy link
Member

@knocte this repository is not about Rust documentation though, it's about the docs.rs service, hosting crates' documentation. The repository for the book is https://github.com/rust-lang/book.

@knocte
Copy link
Author

knocte commented Jul 10, 2019

Well I have to say this is all very confusing for a newbie. If you google "rust docs" you end up here. Probably this repo should be renamed to cratesdocs.rs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants