Skip to content

Allow compiling without libmagic #580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jyn514 opened this issue Feb 1, 2020 · 5 comments
Closed

Allow compiling without libmagic #580

jyn514 opened this issue Feb 1, 2020 · 5 comments
Labels
A-newcomer-roadblock Area: A problem that isn't a bug, but makes it harder for people to contribute

Comments

@jyn514
Copy link
Member

jyn514 commented Feb 1, 2020

This has been an issue for various contributors. I would like to be able to run the test suite (even if not the builds) on architectures other than x86_64 debian.

See https://github.com/bjorn3/rustc_codegen_cranelift/issues/884.

cc @Zexbe
@jyn514 jyn514 added the A-newcomer-roadblock Area: A problem that isn't a bug, but makes it harder for people to contribute label Feb 1, 2020
@jyn514
Copy link
Member Author

jyn514 commented Feb 1, 2020

libmagic is used in add_path_into_database to detect the file type. I wonder if we could get away with having a static database of file extensions?

@Zexbe
Copy link
Contributor

Zexbe commented Feb 1, 2020 •
edited
Loading

Do you always have the file extension? Would this work? https://crates.io/crates/mime_guess

@jyn514
Copy link
Member Author

jyn514 commented Feb 1, 2020

Not all files have file extensions, so this isn't 100% reliable, I was mostly imagining it for local testing where you really only care about .html, .css and .js

@jyn514
Copy link
Member Author

jyn514 commented Feb 1, 2020

But yeah that could work locally

@Zexbe Zexbe mentioned this issue Feb 3, 2020
Closed
@jyn514
Copy link
Member Author

jyn514 commented Feb 23, 2020

Fixed in #600

@jyn514 jyn514 closed this as completed Feb 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-newcomer-roadblock Area: A problem that isn't a bug, but makes it harder for people to contribute
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Build on windows support [WIP, No Merge] Zexbe/docs.rs
2 participants
@Zexbe @jyn514