-
Notifications
You must be signed in to change notification settings - Fork 82
Allow the use of ^
for negation in addition to !
?
#116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
This would also be useful for a project I've been working on, where the incompatibility with Java glob libraries caught us by surprise. I note that @ackerleytng used the workaround of replacing the input string - that would be possible for us too, but it seems like a dangerous thing to do and easy to get wrong. |
There doesn't seem to be much momentum behind this issue (even though PR #141 stands ready to fix it), so let me try to impress some urgency by stating, from the sudo-rs project point of view it would be really good to have this fixed. We really don't have any alternatives (sure, we could move to If there is fear of incompatibility when caret is added, can we modify #141 so that the modifications that @tertsdiepraam proposed are hidden behind a feature flag? That would be perfectly acceptable for us. |
Alternative idea: add a |
I've looked into this a bit again. The extra config option sounds good, but is a bit tricky because there are currently no options that influence the parsing of the |
Would you consider allowing the use of
^
for negation in addition to!
?gnu coreutils supports the use of
^
in addition to!
, based on the behavior ofls
anddu
. I tried finding documentation of this in code, and found this infnmatch.c
Or perhaps, instead of a direct comparison with
'!'
at https:/github.com/rust-lang/glob/blob/master/src/lib.rs#L614, can we call a method likeis_negation_character
? That way, this library can be extended.The text was updated successfully, but these errors were encountered: