Add support for bumpalo #231
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baloo
reviewed
Jan 21, 2021
src/raw/alloc.rs
Outdated
|
|
||
| #[cfg(feature = "bumpalo")] | ||
| unsafe impl Allocator for bumpalo::Bump { | ||
| fn allocate(&self, layout: Layout) -> Result<NonNull<u8>, AllocError> { |
There was a problem hiding this comment.
Just curious, I'm comparing this with the implementation I made upstream, and the signature looks wrong.
allocator_api signature should be NonNull<[u8]>. That makes me require the nonnull_slice_from_raw_parts feature.
It feels like I'm missing something here.
There was a problem hiding this comment.
That's just an internal Allocator trait, it is completely private and can't be implemented outside this crate. As such, it doesn't have to match the standard library Allocator trait.
|
@bors r+ |
|
📌 Commit 5467e3f has been approved by |
|
☀️ Test successful - checks-travis |
This was referenced Mar 15, 2021
This was referenced Mar 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows
Bumpand&Bumpto be used as allocators without the nightly feature.This is currently blocked on fitzgen/bumpalo#92 for support on nightly.