Merge pull request #1667 from JohnTitor/reenable-semver

Re-enable semver check

Author: JohnTitor

ci/azure.yml

@@ -136,26 +136,25 @@ jobs:
         parameters:
           deploy_dir: target/doc
 
-  # FIXME: re-enable these after the next release
-  #- job: SemverLinux
-  #  dependsOn: BuildChannelsLinux
-  #  continueOnError: true
-  #  pool:
-  #    vmImage: ubuntu-18.04
-  #  steps:
-  #    - template: azure-install-rust.yml
-  #    - script: sh ci/semver.sh linux
-  #      displayName: Check breaking changes
+  - job: SemverLinux
+    dependsOn: BuildChannelsLinux
+    continueOnError: true
+    pool:
+      vmImage: ubuntu-18.04
+    steps:
+      - template: azure-install-rust.yml
+      - script: sh ci/semver.sh linux
+        displayName: Check breaking changes
 
-  #- job: SemverOSX
-  #  dependsOn: BuildChannelsOSX
-  #  continueOnError: true
-  #  pool:
-  #    vmImage: macos-10.15
-  #  steps:
-  #    - template: azure-install-rust.yml
-  #    - script: sh ci/semver.sh osx
-  #      displayName: Check breaking changes
+  - job: SemverOSX
+    dependsOn: BuildChannelsOSX
+    continueOnError: true
+    pool:
+      vmImage: macos-10.15
+    steps:
+      - template: azure-install-rust.yml
+      - script: sh ci/semver.sh osx
+        displayName: Check breaking changes
 
   - job: BuildChannelsLinux
     dependsOn: StyleAndDocs

ci/semver.sh

@@ -13,7 +13,10 @@ if ! rustc --version | grep -E "nightly" ; then
     exit 1
 fi
 
-cargo +nightly install semverver
+rustup component add rustc-dev
+
+# FIXME: Use upstream once it gets rustup.
+cargo +nightly install semververfork
 
 TARGETS=
 case "${OS}" in
@@ -73,5 +76,6 @@ for TARGET in $TARGETS; do
         sleep 1
     done
 
-    cargo +nightly semver --api-guidelines --target="${TARGET}"
+    # FIXME: Use upstream once it gets rustup.
+    cargo +nightly semverfork --api-guidelines --target="${TARGET}"
 done

ci/style.sh

@@ -5,7 +5,7 @@ set -ex
 rustc ci/style.rs && ./style src
 
 if rustup component add rustfmt-preview ; then
-    which rustfmt
+    command -v rustfmt
     rustfmt -V
     cargo fmt --all -- --check
 fi

src/lib.rs

@@ -14,14 +14,17 @@
 //! [pd]: https://rust-lang.github.io/libc/#platform-specific-documentation
 #![crate_name = "libc"]
 #![crate_type = "rlib"]
-#![cfg_attr(libc_deny_warnings, deny(warnings))]
+// FIXME: Remove this and redundant_semicolon once renamed lint reaches stable.
+#![allow(renamed_and_removed_lints)]
 #![allow(
     bad_style,
     overflowing_literals,
     improper_ctypes,
     unknown_lints,
-    redundant_semicolon
+    redundant_semicolon,
+    redundant_semicolons
 )]
+#![cfg_attr(libc_deny_warnings, deny(warnings))]
 // Attributes needed when building as part of the standard library
 #![cfg_attr(
     feature = "rustc-dep-of-std",