chore: rework workspace params, MSRV 1.64

* Move common workspace settings to the `[workspace]` sections in the root.
* Remove Cargo settings that are identical to the defaults (per Cargo [recommendations](https://doc.rust-lang.org/cargo/reference/manifest.html))
* Add common clippy lint configuration
* These require MSRV 1.64 `workspace-inheritance` feature
* Fix perl-based method to extract MSRV

Author: nyurik

.github/workflows/ci.yaml

@@ -34,7 +34,7 @@ jobs:
     name: Verify build
     strategy:
       matrix:
-        toolchain: [stable, nightly, 1.63.0]
+        toolchain: [stable, nightly, 1.64.0]
         os: [ubuntu-24.04, macos-14, windows-2022]
         include:
           - toolchain: beta
@@ -49,7 +49,7 @@ jobs:
       - name: Update RUSTFLAGS
         run: |
           set -eux
-          [ "${{ matrix.toolchain }}" = "1.63.0" ] && echo 'RUSTFLAGS=' >> "$GITHUB_ENV" || true
+          [ "${{ matrix.toolchain }}" = "1.64.0" ] && echo 'RUSTFLAGS=' >> "$GITHUB_ENV" || true
           
       - name: Setup Rust toolchain
         run: ./ci/install-rust.sh
@@ -255,7 +255,7 @@ jobs:
     steps:
     - uses: actions/checkout@master
     - run: |
-        msrv="$(perl -ne 'print if s/rust-version\s*=\s*"(.*)"/\1/g' ctest/Cargo.toml)"
+        msrv="$(cargo metadata --format-version 1 | jq -r --arg CRATE_NAME ctest  '.packages | map(select(.name == $CRATE_NAME)) | first | .rust_version')"
         echo "MSRV: $msrv"
         echo "MSRV=$msrv" >> "$GITHUB_ENV"
     - name: Install Rust

Cargo.toml

@@ -1,20 +1,16 @@
 [package]
 name = "libc"
 version = "1.0.0-alpha.1"
-authors = ["The Rust Project Developers"]
-license = "MIT OR Apache-2.0"
-readme = "README.md"
-edition = "2021"
-repository = "https://github.com/rust-lang/libc"
-homepage = "https://github.com/rust-lang/libc"
-documentation = "https://docs.rs/libc/"
 keywords = ["libc", "ffi", "bindings", "operating", "system"]
 categories = ["external-ffi-bindings", "no-std", "os"]
-build = "build.rs"
 exclude = ["/ci/*", "/.github/*", "/.cirrus.yml", "/triagebot.toml"]
-rust-version = "1.63"
 description = "Raw FFI bindings to platform libraries like libc."
 publish = false # On the main branch, we don't want to publish anything
+authors.workspace = true
+edition.workspace = true
+license.workspace = true
+repository.workspace = true
+rust-version.workspace = true
 
 [package.metadata.docs.rs]
 features = ["extra_traits"]
@@ -140,9 +136,36 @@ std = []
 rustc-dep-of-std = ["rustc-std-workspace-core"]
 extra_traits = []
 
+[lints]
+workspace = true
+
 [workspace]
 members = [
     "ctest",
     "ctest-test",
     "libc-test",
 ]
+
+[workspace.package]
+authors = ["The Rust Project Developers"]
+license = "MIT OR Apache-2.0"
+edition = "2021"
+repository = "https://github.com/rust-lang/libc"
+rust-version = "1.64"
+
+[workspace.lints.rust]
+# TODO: make idents consistent in each file
+# unused_qualifications = "warn"
+
+[workspace.lints.clippy]
+# TODO: all these are default lints and should probably be fixed
+identity_op = "allow"
+if_same_then_else = "allow"
+missing_safety_doc = "allow"
+non_minimal_cfg = "allow"
+precedence = "allow"
+redundant_field_names = "allow"
+redundant_static_lifetimes = "allow"
+unnecessary_cast = "allow"
+unused_unit = "allow"
+zero_ptr = "allow"

README.md

@@ -51,7 +51,7 @@ libc = "0.2"
 
 ## Rust version support
 
-The minimum supported Rust toolchain version is currently **Rust 1.63**.
+The minimum supported Rust toolchain version is currently **Rust 1.64**.
 
 Increases to the MSRV are allowed to change without a major (i.e. semver-
 breaking) release in order to avoid a ripple effect in the ecosystem. A policy

ctest-test/Cargo.toml

@@ -2,9 +2,11 @@
 name = "ctest-test"
 version = "0.1.0"
 authors = ["Alex Crichton <[email protected]>"]
-build = "build.rs"
-edition = "2021"
 publish = false
+edition.workspace = true
+
+[lints]
+workspace = true
 
 [build-dependencies]
 ctest = { path = "../ctest" }

ctest/Cargo.toml

@@ -1,17 +1,15 @@
 [package]
 name = "ctest"
 version = "0.4.11"
-license = "MIT OR Apache-2.0"
-readme = "README.md"
-repository = "https://github.com/rust-lang/libc"
-homepage = "https://github.com/rust-lang/libc"
-documentation = "https://docs.rs/ctest"
-description = """
-Automated tests of FFI bindings.
-"""
+description = "Automated tests of FFI bindings."
 exclude = ["CHANGELOG.md"]
-edition = "2021"
-rust-version = "1.63.0"
+edition.workspace = true
+license.workspace = true
+repository.workspace = true
+rust-version.workspace = true
+
+[lints]
+workspace = true
 
 [dependencies]
 garando_syntax = "0.1"

ctest/README.md

@@ -10,7 +10,7 @@ APIs in Rust match the APIs defined in C.
 
 ## MSRV (Minimum Supported Rust Version)
 
-The MSRV is 1.63.0 because of the transitive dependencies.
+The MSRV is 1.64.0 because of the transitive dependencies.
 Note that MSRV may be changed anytime by dependencies.
 
 ## Example

libc-test/Cargo.toml

@@ -1,16 +1,15 @@
 [package]
 name = "libc-test"
 version = "0.1.0"
-edition = "2021"
-authors = ["The Rust Project Developers"]
-license = "MIT OR Apache-2.0"
-build = "build.rs"
+description = "A test crate for the libc crate."
 publish = false
-repository = "https://github.com/rust-lang/libc"
-homepage = "https://github.com/rust-lang/libc"
-description = """
-A test crate for the libc crate.
-"""
+authors.workspace = true
+edition.workspace = true
+license.workspace = true
+repository.workspace = true
+
+[lints]
+workspace = true
 
 [dependencies]
 cfg-if = "1.0.0"