Skip to content
This repository was archived by the owner on Feb 5, 2019. It is now read-only.

Commit c97e080

Browse files
committed
Partially revert r308329 to fix MSVC
This is an attempt to fix an upstream bug at https://bugs.llvm.org/show_bug.cgi?id=36096 by applying the local solution found there and otherwise reverting the behavior that seems to be causing problems for us. I'm not actually sure what's going on here, but hopefully it's not too bad for us...
1 parent d67f525 commit c97e080

File tree

1 file changed

+1
-2
lines changed

1 file changed

+1
-2
lines changed

lib/Object/ArchiveWriter.cpp

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -294,8 +294,7 @@ static bool isArchiveSymbol(const object::BasicSymbolRef &S) {
294294
return false;
295295
if (!(Symflags & object::SymbolRef::SF_Global))
296296
return false;
297-
if (Symflags & object::SymbolRef::SF_Undefined &&
298-
!(Symflags & object::SymbolRef::SF_Indirect))
297+
if (Symflags & object::SymbolRef::SF_Undefined)
299298
return false;
300299
return true;
301300
}

0 commit comments

Comments
 (0)