Revert "Remove 2024 unsafe extern block notes"

This reverts commit 875b905.

Author: ehuss

src/items/external-blocks.md

@@ -2,7 +2,7 @@
 
 > **<sup>Syntax</sup>**\
 > _ExternBlock_ :\
-> &nbsp;&nbsp; `unsafe`<sup>?</sup> `extern` [_Abi_]<sup>?</sup> `{`\
+> &nbsp;&nbsp; `unsafe`<sup>?</sup>[^unsafe-2024] `extern` [_Abi_]<sup>?</sup> `{`\
 > &nbsp;&nbsp; &nbsp;&nbsp; [_InnerAttribute_]<sup>\*</sup>\
 > &nbsp;&nbsp; &nbsp;&nbsp; _ExternalItem_<sup>\*</sup>\
 > &nbsp;&nbsp; `}`
@@ -12,6 +12,8 @@
 > &nbsp;&nbsp; &nbsp;&nbsp; &nbsp;&nbsp; [_MacroInvocationSemi_]\
 > &nbsp;&nbsp; &nbsp;&nbsp; | ( [_Visibility_]<sup>?</sup> ( [_StaticItem_] | [_Function_] ) )\
 > &nbsp;&nbsp; )
+>
+> [^unsafe-2024]: Starting with the 2024 Edition, the `unsafe` keyword is required semantically.
 
 External blocks provide _declarations_ of items that are not _defined_ in the
 current crate and are the basis of Rust's foreign function interface. These are
@@ -23,6 +25,11 @@ blocks is only allowed in an `unsafe` context.
 
 The external block defines its functions and statics in the [value namespace] of the module or block where it is located.
 
+**Edition differences**: Starting in the 2024 edition, the `unsafe` keyword is
+required to appear before the `extern` keyword on external blocks. In previous
+editions, it is accepted but not required. The `safe` and `unsafe` item qualifiers
+are only allowed if the external block itself is marked as `unsafe`.
+
 ## Functions
 
 Functions within external blocks are declared in the same way as other Rust

src/items/functions.md

@@ -8,7 +8,7 @@
 >       ( [_BlockExpression_] | `;` )
 >
 > _FunctionQualifiers_ :\
-> &nbsp;&nbsp; `const`<sup>?</sup> `async`[^async-edition]<sup>?</sup> _ItemSafety_<sup>?</sup> (`extern` _Abi_<sup>?</sup>)<sup>?</sup>
+> &nbsp;&nbsp; `const`<sup>?</sup> `async`[^async-edition]<sup>?</sup> _ItemSafety_<sup>?</sup>[^extern-qualifiers] (`extern` _Abi_<sup>?</sup>)<sup>?</sup>
 >
 > _ItemSafety_ :\
 > &nbsp;&nbsp; `safe`[^extern-safe] | `unsafe`
@@ -45,6 +45,10 @@
 > [^extern-safe]: The `safe` function qualifier is only allowed semantically within
 >   `extern` blocks.
 >
+> [^extern-qualifiers]: *Relevant to editions earlier than Rust 2024*: Within
+>   `extern` blocks, the `safe` or `unsafe` function qualifier is only allowed
+>   when the `extern` is qualified as `unsafe`.
+>
 > [^fn-param-2015]: Function parameters with only a type are only allowed
 >   in an associated function of a [trait item] in the 2015 edition.
 

src/unsafe-keyword.md

@@ -61,6 +61,8 @@ Unsafe trait implementations are the logical dual to unsafe traits: where unsafe
 
 The programmer who declares an [external block] must assure that the signatures of the items contained within are correct. Failing to do so may lead to undefined behavior.  That this obligation has been met is indicated by writing `unsafe extern`.
 
+**Edition differences**: Prior to edition 2024, `extern` blocks were allowed without being qualified as `unsafe`.
+
 [external block]: items/external-blocks.md
 
 ## Unsafe attributes (`#[unsafe(attr)]`)

src/unsafety.md

@@ -11,9 +11,11 @@ Rust:
 - Accessing a field of a [`union`], other than to assign to it.
 - Calling an unsafe function (including an intrinsic or foreign function).
 - Implementing an [unsafe trait].
-- Declaring an [`extern`] block.
+- Declaring an [`extern`] block[^extern-2024].
 - Applying an [unsafe attribute] to an item.
 
+[^extern-2024]: Prior to the 2024 edition, extern blocks were allowed to be declared without `unsafe`.
+
 [`extern`]: items/external-blocks.md
 [`union`]: items/unions.md
 [mutable]: items/static-items.md#mutable-statics