Skip to content

Commit 8f9ca96

Browse files
committed
ci: remove minimal version check
It's impossible to do this without the cooperation of maintainers from other core crates, and some of them do not see the value in doing this.
1 parent 2316432 commit 8f9ca96

File tree

1 file changed

+15
-3
lines changed

1 file changed

+15
-3
lines changed

Diff for: ci/script.sh

+15-3
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,19 @@ if [ "$TRAVIS_RUST_VERSION" = "nightly" ]; then
4949
(cd bench && ./run rust --no-run --verbose)
5050

5151
# Test minimal versions.
52-
cargo +nightly generate-lockfile -Z minimal-versions
53-
cargo build --verbose
54-
cargo test --verbose
52+
#
53+
# For now, we remove this check, because it doesn't seem possible to convince
54+
# some maintainers of *core* crates that this is a worthwhile test to add.
55+
# In particular, this test uncovers any *incorrect* dependency specification
56+
# in the chain of dependencies.
57+
#
58+
# We might consider figuring out how to migrate off of rand in order to get
59+
# this check working. (This will be hard, since it either requires dropping
60+
# quickcheck or migrating quickcheck off of rand, which is just probably
61+
# not practical.)
62+
#
63+
# So frustrating.
64+
# cargo +nightly generate-lockfile -Z minimal-versions
65+
# cargo build --verbose
66+
# cargo test --verbose
5567
fi

0 commit comments

Comments
 (0)