Skip to content

Commit b3e5fd2

Browse files
committed
regex: remove old regex-syntax crate
This commit does the mechanical changes necessary to remove the old regex-syntax crate and replace it with the rewrite. The rewrite now subsumes the `regex-syntax` crate name, and gets a semver bump to 0.5.0.
1 parent efff9fa commit b3e5fd2

40 files changed

+793
-14718
lines changed

Diff for: Cargo.toml

+2-3
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ appveyor = { repository = "rust-lang-libs/regex" }
1919

2020
[workspace]
2121
members = [
22-
"bench", "regex-capi", "regex-debug", "regex-syntax", "regex-syntax-2",
22+
"bench", "regex-capi", "regex-debug", "regex-syntax",
2323
]
2424

2525
[dependencies]
@@ -30,8 +30,7 @@ memchr = "2.0.0"
3030
# For managing regex caches quickly across multiple threads.
3131
thread_local = "0.3.2"
3232
# For parsing regular expressions.
33-
regex-syntax = { path = "regex-syntax", version = "0.4.1" }
34-
regex-syntax2 = { path = "regex-syntax-2", version = "0.5.0" }
33+
regex-syntax = { path = "regex-syntax", version = "0.5.0" }
3534
# For accelerating text search.
3635
simd = { version = "0.2.1", optional = true }
3736
# For compiling UTF-8 decoding into automata.

Diff for: bench/Cargo.toml

+1-1
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ onig = { version = "3", optional = true }
1919
libpcre-sys = { version = "0.2", optional = true }
2020
memmap = "0.6"
2121
regex = { version = "0.2.0", path = "..", features = ["simd-accel"] }
22-
regex-syntax = { version = "0.4.0", path = "../regex-syntax" }
22+
regex-syntax = { version = "0.5.0", path = "../regex-syntax" }
2323
serde = "1"
2424
serde_derive = "1"
2525

Diff for: bench/src/rust_compile.rs

+7-7
Original file line numberDiff line numberDiff line change
@@ -8,23 +8,23 @@
88
// option. This file may not be copied, modified, or distributed
99
// except according to those terms.
1010

11-
use regex_syntax::Expr;
11+
use regex_syntax::Parser;
1212
use test::Bencher;
1313

1414
use regex::internal::Compiler;
1515

1616
#[bench]
1717
fn compile_simple(b: &mut Bencher) {
1818
b.iter(|| {
19-
let re = Expr::parse(r"^bc(d|e)*$").unwrap();
19+
let re = Parser::new().parse(r"^bc(d|e)*$").unwrap();
2020
Compiler::new().compile(&[re]).unwrap()
2121
});
2222
}
2323

2424
#[bench]
2525
fn compile_simple_bytes(b: &mut Bencher) {
2626
b.iter(|| {
27-
let re = Expr::parse(r"^bc(d|e)*$").unwrap();
27+
let re = Parser::new().parse(r"^bc(d|e)*$").unwrap();
2828
Compiler::new().bytes(true).compile(&[re]).unwrap()
2929
});
3030
}
@@ -39,15 +39,15 @@ fn compile_simple_full(b: &mut Bencher) {
3939
#[bench]
4040
fn compile_small(b: &mut Bencher) {
4141
b.iter(|| {
42-
let re = Expr::parse(r"\p{L}|\p{N}|\s|.|\d").unwrap();
42+
let re = Parser::new().parse(r"\p{L}|\p{N}|\s|.|\d").unwrap();
4343
Compiler::new().compile(&[re]).unwrap()
4444
});
4545
}
4646

4747
#[bench]
4848
fn compile_small_bytes(b: &mut Bencher) {
4949
b.iter(|| {
50-
let re = Expr::parse(r"\p{L}|\p{N}|\s|.|\d").unwrap();
50+
let re = Parser::new().parse(r"\p{L}|\p{N}|\s|.|\d").unwrap();
5151
Compiler::new().bytes(true).compile(&[re]).unwrap()
5252
});
5353
}
@@ -62,15 +62,15 @@ fn compile_small_full(b: &mut Bencher) {
6262
#[bench]
6363
fn compile_huge(b: &mut Bencher) {
6464
b.iter(|| {
65-
let re = Expr::parse(r"\p{L}{100}").unwrap();
65+
let re = Parser::new().parse(r"\p{L}{100}").unwrap();
6666
Compiler::new().compile(&[re]).unwrap()
6767
});
6868
}
6969

7070
#[bench]
7171
fn compile_huge_bytes(b: &mut Bencher) {
7272
b.iter(|| {
73-
let re = Expr::parse(r"\p{L}{100}").unwrap();
73+
let re = Parser::new().parse(r"\p{L}{100}").unwrap();
7474
Compiler::new().bytes(true).compile(&[re]).unwrap()
7575
});
7676
}

Diff for: regex-debug/Cargo.toml

+1-2
Original file line numberDiff line numberDiff line change
@@ -13,8 +13,7 @@ workspace = ".."
1313
[dependencies]
1414
docopt = "0.8"
1515
regex = { version = "0.2", path = ".." }
16-
regex-syntax = { version = "0.4.0", path = "../regex-syntax" }
17-
regex-syntax2 = { version = "0.5.0", path = "../regex-syntax-2" }
16+
regex-syntax = { version = "0.5.0", path = "../regex-syntax" }
1817
serde = "1"
1918
serde_derive = "1"
2019
utf8-ranges = "1"

Diff for: regex-debug/src/main.rs

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
extern crate docopt;
22
extern crate regex;
3-
extern crate regex_syntax2 as syntax;
3+
extern crate regex_syntax as syntax;
44
extern crate serde;
55
#[macro_use]
66
extern crate serde_derive;

Diff for: regex-syntax-2/Cargo.toml

-13
This file was deleted.

Diff for: regex-syntax-2/benches/bench.rs

-73
This file was deleted.

0 commit comments

Comments
 (0)