parser/grammar: Disallow let statements to end with optional semicolon

Author: MarijnS95

crates/parser/src/grammar/expressions.rs

@@ -67,7 +67,7 @@ pub(super) fn stmt(p: &mut Parser, with_semi: StmtWithSemi) {
     attributes::outer_attrs(p);
 
     if p.at(T![let]) {
-        let_stmt(p, m, with_semi);
+        let_stmt(p, m);
         return;
     }
 
@@ -147,8 +147,7 @@ pub(super) fn stmt(p: &mut Parser, with_semi: StmtWithSemi) {
     //     let _: ! = {};
     //     let f = #[attr]||{};
     // }
-    fn let_stmt(p: &mut Parser, m: Marker, with_semi: StmtWithSemi) {
-        assert!(p.at(T![let]));
+    fn let_stmt(p: &mut Parser, m: Marker) {
         p.bump(T![let]);
         patterns::pattern(p);
         if p.at(T![:]) {
@@ -157,18 +156,7 @@ pub(super) fn stmt(p: &mut Parser, with_semi: StmtWithSemi) {
         if p.eat(T![=]) {
             expressions::expr_with_attrs(p);
         }
-
-        match with_semi {
-            StmtWithSemi::Yes => {
-                p.expect(T![;]);
-            }
-            StmtWithSemi::No => {}
-            StmtWithSemi::Optional => {
-                if p.at(T![;]) {
-                    p.eat(T![;]);
-                }
-            }
-        }
+        p.expect(T![;]);
         m.complete(p, LET_STMT);
     }
 }