Merge pull request #19522 from davidbarsky/davidbarsky/fix-panic-in-view-crate-graph

Veykril · web-flow · commit 2261e4e8928c · 2025-04-04T16:00:18.000Z
internal: fix panic in `view_crate_graph`
diff --git a/crates/ide/src/view_crate_graph.rs b/crates/ide/src/view_crate_graph.rs
@@ -1,4 +1,5 @@
 use dot::{Id, LabelText};
+use ide_db::base_db::salsa::plumbing::AsId;
 use ide_db::{
     FxHashMap, RootDatabase,
     base_db::{
@@ -78,7 +79,8 @@ impl<'a> dot::Labeller<'a, Crate, Edge<'a>> for DotCrateGraph<'_> {
     }
 
     fn node_id(&'a self, n: &Crate) -> Id<'a> {
-        Id::new(format!("_{:?}", n)).unwrap()
+        let id = n.as_id().as_u32();
+        Id::new(format!("_{:?}", id)).unwrap()
     }
 
     fn node_shape(&'a self, _node: &Crate) -> Option<LabelText<'a>> {

Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,5 @@`
`1`	`1`	`use dot::{Id, LabelText};`
	`2`	`+use ide_db::base_db::salsa::plumbing::AsId;`
`2`	`3`	`use ide_db::{`
`3`	`4`	`FxHashMap, RootDatabase,`
`4`	`5`	`base_db::{`
`@@ -78,7 +79,8 @@ impl<'a> dot::Labeller<'a, Crate, Edge<'a>> for DotCrateGraph<'_> {`
`78`	`79`	`}`
`79`	`80`
`80`	`81`	`fn node_id(&'a self, n: &Crate) -> Id<'a> {`
`81`		`- Id::new(format!("_{:?}", n)).unwrap()`
	`82`	`+ let id = n.as_id().as_u32();`
	`83`	`+ Id::new(format!("_{:?}", id)).unwrap()`
`82`	`84`	`}`
`83`	`85`
`84`	`86`	`fn node_shape(&'a self, _node: &Crate) -> Option<LabelText<'a>> {`