fix: inline editor.replace() calls in reorder_fields assist

Signed-off-by: Tarek <[email protected]>

Author: tareknaser

crates/ide-assists/src/handlers/reorder_fields.rs

@@ -1,10 +1,7 @@
 use either::Either;
 use ide_db::FxHashMap;
 use itertools::Itertools;
-use syntax::{
-    ast, ast::syntax_factory::SyntaxFactory, syntax_editor::SyntaxEditor, AstNode, SmolStr,
-    SyntaxElement, ToSmolStr,
-};
+use syntax::{ast, ast::syntax_factory::SyntaxFactory, AstNode, SmolStr, SyntaxElement, ToSmolStr};
 
 use crate::{AssistContext, AssistId, AssistKind, Assists};
 
@@ -79,10 +76,14 @@ pub(crate) fn reorder_fields(acc: &mut Assists, ctx: &AssistContext<'_>) -> Opti
 
             match fields {
                 Either::Left((sorted, field_list)) => {
-                    replace(&mut editor, field_list.fields(), sorted)
+                    field_list.fields().zip(sorted).for_each(|(field, sorted_field)| {
+                        editor.replace(field.syntax(), sorted_field.syntax().clone_for_update());
+                    });
                 }
                 Either::Right((sorted, field_list)) => {
-                    replace(&mut editor, field_list.fields(), sorted)
+                    field_list.fields().zip(sorted).for_each(|(field, sorted_field)| {
+                        editor.replace(field.syntax(), sorted_field.syntax().clone_for_update());
+                    });
                 }
             }
 
@@ -92,16 +93,6 @@ pub(crate) fn reorder_fields(acc: &mut Assists, ctx: &AssistContext<'_>) -> Opti
     )
 }
 
-fn replace<T: AstNode + PartialEq>(
-    editor: &mut SyntaxEditor,
-    fields: impl Iterator<Item = T>,
-    sorted_fields: impl IntoIterator<Item = T>,
-) {
-    fields.zip(sorted_fields).for_each(|(field, sorted_field)| {
-        editor.replace(field.syntax(), sorted_field.syntax().clone_for_update())
-    });
-}
-
 fn compute_fields_ranks(
     path: &ast::Path,
     ctx: &AssistContext<'_>,