Closing "A request has failed." notification opens output panel

[nyanpasu64]

In the VS Code plugin, if I close the "A request has failed." with the close button, or it gets automatically closed by a second identical message, it opens the output panel automatically. I expect it to only happen when I press the "Go to output" button.

As to how I'm getting so many crashes that it's becoming a nuisance... well, #10386.

I'm on VS Code plugin version v0.3.763.

[lnicola]

Probably a duplicate of microsoft/vscode-languageserver-node#786.

[nyanpasu64]

How is this a duplicate? That bug was filed in a different repository (and this repository doesn't seem to be a fork of that, and I'm not sure if and how the rust-analyzer extension depends on it), was resolved 2.5 months ago, and the bug is still present in the rust-analyzer extension. When will it be fixed here?

[bjorn3]

and this repository doesn't seem to be a fork of that, and I'm not sure if and how the rust-analyzer extension depends on it

The vscode extension uses vscode-languageserver-node to communicate with the rust-analyzer language server. Vscode doesn't have an LSP implementation itself. All vscode LSP based extensions need to use this package.

https://github.com/rust-analyzer/rust-analyzer/blob/237ea0d34dced3444486931f68e87cd07f52b6a8/editors/code/package.json#L41

was resolved 2.5 months ago, and the bug is still present in the rust-analyzer extension.

Maybe updating the dependency version will work? Updating could be non-trivial though. We are currently using 7.1.0-next.5. The main branch on which it should be fixed is 8.0.0-next.2: https://github.com/microsoft/vscode-languageserver-node/blob/10b56de150ad67c3c330da8e2df53ebf2cf347c4/client/package.json#L4

[lnicola]

Yeah, sorry about it. The bug was in the Code LSP client, but I missed the new release (I had the page in an open tab). Filed #10421 for it.

[nyanpasu64]

Thanks for the fix!