Skip to content

More unknown types in webrender after #12993 #13030

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
lnicola opened this issue Aug 15, 2022 · 3 comments · Fixed by #13034
Closed

More unknown types in webrender after #12993 #13030

lnicola opened this issue Aug 15, 2022 · 3 comments · Fixed by #13034

Comments

@lnicola
Copy link
Member

lnicola commented Aug 15, 2022

image

I don't know how this happened, but we're reporting more unknown types in the bitflags! expansions.

webrender is https://github.com/rust-lang/rustc-perf.git at c52ee623e231e7690a93be88d943016968c1036b.

EDIT:

Looks like manually expanding that macro makes the errors go away. Repro, note that the second item is needed:

# bitflags = "1.0"

use bitflags::bitflags;

bitflags! {
    #[repr(C)]
    pub struct FontInstanceFlags: u32 {
        const SYNTHETIC_ITALICS = 1 << 0;
        const SYNTHETIC_BOLD    = 1 << 1;
    }
}

Are we choking on $crate?

@lnicola
Copy link
Member Author

lnicola commented Aug 15, 2022

CC @lowr

@lowr
Copy link
Contributor

lowr commented Aug 17, 2022

cc #12993

For future reference, we were failing to resolve the try!() macro used without escaping in Rust 2015 crates.

@lnicola
Copy link
Member Author

lnicola commented Aug 17, 2022

Makes more sense than crate. Somehow I missed those in the expansion 😕.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants