Skip to content

Toggle inlay hints is not working #13144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
JosuGZ opened this issue Aug 30, 2022 · 11 comments
Closed

Toggle inlay hints is not working #13144

JosuGZ opened this issue Aug 30, 2022 · 11 comments

Comments

@JosuGZ
Copy link

JosuGZ commented Aug 30, 2022

Toggle inlay hints in RA has stopped working for me. Now, it is changing the following setting to an incorrect value:

image

rust-analyzer version: 0.3.1186-standalone (e8e598f 2022-08-28)

rustc version: rustc 1.63.0 (4b91a6ea7 2022-08-08)

relevant settings: In Keyboard settings (VS Code):

    {
        "key": "ctrl+alt+h",
        "command": "rust-analyzer.toggleInlayHints"
    }
@lnicola
Copy link
Member

lnicola commented Aug 30, 2022

Which version of Code is that?

@JosuGZ
Copy link
Author

JosuGZ commented Aug 30, 2022

Which version of Code is that?

I have checked and it is not the latest, but it is not very old. For some reason is failing to update.

@lnicola
Copy link
Member

lnicola commented Aug 30, 2022

We only support the latest one or two versions of code, and yours is from March or even older.

@JosuGZ
Copy link
Author

JosuGZ commented Aug 30, 2022

We only support the latest one or two versions of code, and yours is from March or even older.

Then it would be interesting if RA didn't update if the VS Code version is old. Right now if you have a virtual machine for a project it will break itself after a while :'(

@lnicola
Copy link
Member

lnicola commented Aug 30, 2022

We didn't bump the required version this time, since it works fine (except for this command, which we'd like to remove anyway). You should probably disable extension updates if you want it to never change.

@lnicola
Copy link
Member

lnicola commented Sep 19, 2022

The command was removed in #13215.

@lnicola lnicola closed this as not planned Won't fix, can't repro, duplicate, stale Sep 19, 2022
@c-git
Copy link

c-git commented Feb 22, 2023

Rust Analyzer: Toggle Inlay Hints still shows in the docs here https://code.visualstudio.com/docs/languages/rust but I couldn't find it in VS code and started searching and got to here. I'm new to VS Code so wasn't sure if I was doing something wrong.

@lnicola
Copy link
Member

lnicola commented Feb 22, 2023

@c-git the command was removed in favour of the native feature of Code: the {on,off}UnlessPressed settings from https://code.visualstudio.com/updates/v1_67#_toggle-inlay-hints. The docs there must be a little outdated.

@lnicola
Copy link
Member

lnicola commented Feb 22, 2023

Filed microsoft/vscode-docs#6061 to update the docs.

@c-git
Copy link

c-git commented Feb 22, 2023

Thank you, sorry I wasn't clear. I wasn't sure how to update the docs but understood it had been removed. Thank you for doing the docs update.

@lnicola
Copy link
Member

lnicola commented Feb 22, 2023

No worries, I didn't know myself, but there's a big Edit button in the corner, in case you ever need it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants