Skip to content

Rethink hir-def and hir-expand #17937

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Veykril opened this issue Aug 21, 2024 · 0 comments
Open

Rethink hir-def and hir-expand #17937

Veykril opened this issue Aug 21, 2024 · 0 comments
Labels
A-macro macro expansion A-nameres name, path and module resolution C-Architecture Big architectural things which we need to figure up-front (or suggestions for rewrites :0) ) C-enhancement Category: enhancement

Comments

@Veykril
Copy link
Member

Veykril commented Aug 21, 2024

#17936 shows that some macros can in fact depend on the module hierarchy (in fact, include does too but we managed to get around that by luck it seems), so while the split makes sense, something here feels wrong.
@Veykril Veykril added C-Architecture Big architectural things which we need to figure up-front (or suggestions for rewrites :0) ) A-macro macro expansion A-nameres name, path and module resolution C-enhancement Category: enhancement labels Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-macro macro expansion A-nameres name, path and module resolution C-Architecture Big architectural things which we need to figure up-front (or suggestions for rewrites :0) ) C-enhancement Category: enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Veykril