Skip to content

Pin used proc-macro-srv nightly version heuristically? #19599

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Veykril opened this issue Apr 16, 2025 · 5 comments · Fixed by #19600
Closed

Pin used proc-macro-srv nightly version heuristically? #19599

Veykril opened this issue Apr 16, 2025 · 5 comments · Fixed by #19600
Labels
A-infra CI and workflow issues

Comments

@Veykril
Copy link
Member

Veykril commented Apr 16, 2025

          Looks like a rustc sync is needed after https://github.com/rust-lang/rust/pull/139671.

Originally posted by @Kobzol in #19597 (comment)

The proc-macro-srv CI step can be quite annoying when changes happen upstream regarding libproc-macro. I wonder if we can smartly pin the nightly used to the last synced rust-lang/rust version?

@Veykril Veykril added the A-infra CI and workflow issues label Apr 16, 2025
@Veykril
Copy link
Member Author

Veykril commented Apr 16, 2025

@lnicola maybe you got some ideas here given you know how syncs go from usually. Maybe it suffices to just bump the nightly used in CI to the nightly of when you do a sync? (iirc we use an xtask for syncing so that bump can be done automatigcally with that)

@Kobzol
Copy link
Contributor

Kobzol commented Apr 16, 2025

One issue with that is that the synced commit might not necessarily correspond to a nightly (we could find the nearest nightly, I suppose, but that might be "in the future" at the time of sync). Another alternative is to use https://github.com/kennytm/rustup-toolchain-install-master and just install the commit from rust-version.

@Kobzol
Copy link
Contributor

Kobzol commented Apr 16, 2025

Trying that in #19600.

@Kobzol
Copy link
Contributor

Kobzol commented Apr 16, 2025

Looks like it works :)

@Veykril
Copy link
Member Author

Veykril commented Apr 16, 2025

Oh sweet, we can in fact use the rust-version file. I was wondering about that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-infra CI and workflow issues
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants