-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Pin used proc-macro-srv nightly version heuristically? #19599
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
@lnicola maybe you got some ideas here given you know how syncs go from usually. Maybe it suffices to just bump the nightly used in CI to the nightly of when you do a sync? (iirc we use an xtask for syncing so that bump can be done automatigcally with that) |
One issue with that is that the synced commit might not necessarily correspond to a nightly (we could find the nearest nightly, I suppose, but that might be "in the future" at the time of sync). Another alternative is to use https://github.com/kennytm/rustup-toolchain-install-master and just install the commit from |
Trying that in #19600. |
Looks like it works :) |
Oh sweet, we can in fact use the rust-version file. I was wondering about that. |
Originally posted by @Kobzol in #19597 (comment)
The proc-macro-srv CI step can be quite annoying when changes happen upstream regarding libproc-macro. I wonder if we can smartly pin the nightly used to the last synced rust-lang/rust version?
The text was updated successfully, but these errors were encountered: