Skip to content

nightly 0.4.2429 build produce a related to snippets warning in vscode #19641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
MaxGraey opened this issue Apr 20, 2025 · 2 comments · Fixed by #19642
Closed

nightly 0.4.2429 build produce a related to snippets warning in vscode #19641

MaxGraey opened this issue Apr 20, 2025 · 2 comments · Fixed by #19642
Labels
A-config configuration A-ide general IDE features

Comments

@MaxGraey
Copy link

Hi! With latest nightly update (0.4.2429) I see a warning in vscode:

Invalid config value: /completion/snippets/custom: invalid type: null, expected a map;
@MaxGraey MaxGraey added the Broken Window Bugs / technical debt to be addressed immediately label Apr 20, 2025
@MaxGraey MaxGraey changed the title nightly 0.4.2429 buid produce a related to snippets warning in vscode nightly 0.4.2429 build produce a related to snippets warning in vscode Apr 20, 2025
@ChayimFriedman2 ChayimFriedman2 added A-ide general IDE features A-config configuration and removed Broken Window Bugs / technical debt to be addressed immediately labels Apr 20, 2025
@roife
Copy link
Member

roife commented Apr 21, 2025

This issue remains unresolved; I can still reproduce the bug after commit 19642.

The problem is located in the following code: https://github.com/ChayimFriedman2/rust-analyzer/blob/8497fc321cad420b923e15f600106f8e22324930/crates/rust-analyzer/src/config.rs#L936-L945.

The function get_field_json would take the value of completion_snippets_custom, which results in this field becoming null, but the configuration will be read again later.

@roife roife reopened this Apr 21, 2025
@roife
Copy link
Member

roife commented Apr 21, 2025

Oh, I didn't notice #19636; It can be confirmed that #19636 fixed this issue.

@Veykril Veykril closed this as completed Apr 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-config configuration A-ide general IDE features
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants