Skip to content

Flip default of diagnostic experimentality #19673

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Veykril opened this issue Apr 23, 2025 · 2 comments · Fixed by #19772
Closed

Flip default of diagnostic experimentality #19673

Veykril opened this issue Apr 23, 2025 · 2 comments · Fixed by #19772
Labels
A-diagnostics diagnostics / error reporting E-easy

Comments

@Veykril
Copy link
Member

Veykril commented Apr 23, 2025 •
edited by davidbarsky
Loading

I wonder if it would help to invert this, so non-experimental diagnostics have to be explicitly marked as stable? IMO all diagnostics should start out experimental, and "stabilizing" them should at least require that they don't have false positives on some number of code bases.

Originally posted by @flodiebold in #19670 (comment)
@Veykril Veykril added E-easy A-diagnostics diagnostics / error reporting labels Apr 23, 2025
@ChayimFriedman2
Copy link
Contributor

I support this. I also think that we can (should) have a CI pass that runs diagnostics on some codebases when a diagnostic is stabilized, and see if there are any diagnostics of the stabilized error code.

@Veykril
Copy link
Member Author

Veykril commented Apr 24, 2025

Oh ye that sounds like a nice idea

@flodiebold flodiebold mentioned this issue May 9, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-diagnostics diagnostics / error reporting E-easy
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

internal: Make diagnostics experimental by default rust-lang/rust-analyzer
2 participants
@Veykril @ChayimFriedman2