Skip to content

HirDisplay should display impl Fn* for closures when the target is SourceCode #8147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Veykril opened this issue Mar 22, 2021 · 1 comment
Closed

HirDisplay should display impl Fn* for closures when the target is SourceCode #8147

Veykril opened this issue Mar 22, 2021 · 1 comment
Labels
S-unactionable Issue requires feedback, design decisions or is blocked on other work

Comments

@Veykril
Copy link
Member

Veykril commented Mar 22, 2021

After #8144 we error on displaying closures when the target is SourceCode to prevent panics from trying to use this output for make::ty, ideally we want to instead emit impl Fn* as thats the closest to a closure type we can get. For that we require more knowledge about what kind of closure we are dealing with though which is currently not something we have the analysis for.
@Veykril Veykril added the S-unactionable Issue requires feedback, design decisions or is blocked on other work label Mar 22, 2021
@HKalbasi
Copy link
Member

fixed in #14470

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
S-unactionable Issue requires feedback, design decisions or is blocked on other work
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Veykril @HKalbasi