Includes TODO for constants equivalent to π/180

thiagoarrais · thiagoarrais · commit 3065201eb3a0 · 2020-07-06T13:45:43.000-03:00
diff --git a/clippy_lints/src/floating_point_arithmetic.rs b/clippy_lints/src/floating_point_arithmetic.rs
@@ -665,6 +665,7 @@ fn check_radians(cx: &LateContext<'_>, expr: &Expr<'_>) {
         if let Some((rvalue, _)) = constant(cx, cx.tables(), div_rhs);
         if let Some((lvalue, _)) = constant(cx, cx.tables(), mul_rhs);
         then {
+            // TODO: also check for constant values near PI/180 or 180/PI
             if (F32(f32_consts::PI) == rvalue || F64(f64_consts::PI) == rvalue) &&
                (F32(180_f32) == lvalue || F64(180_f64) == lvalue)
             {

Original file line number	Diff line number	Diff line change
`@@ -665,6 +665,7 @@ fn check_radians(cx: &LateContext<'_>, expr: &Expr<'_>) {`
`665`	`665`	`if let Some((rvalue, _)) = constant(cx, cx.tables(), div_rhs);`
`666`	`666`	`if let Some((lvalue, _)) = constant(cx, cx.tables(), mul_rhs);`
`667`	`667`	`then {`
	`668`	`+ // TODO: also check for constant values near PI/180 or 180/PI`
`668`	`669`	`if (F32(f32_consts::PI) == rvalue \|\| F64(f64_consts::PI) == rvalue) &&`
`669`	`670`	`(F32(180_f32) == lvalue \|\| F64(180_f64) == lvalue)`
`670`	`671`	`{`