refactor it

Author: Centri3

clippy_lints/src/len_zero.rs

@@ -1,5 +1,4 @@
 use clippy_utils::diagnostics::{span_lint, span_lint_and_sugg, span_lint_and_then};
-use clippy_utils::higher::{IfOrIfLetInChain, LetChain};
 use clippy_utils::source::snippet_with_context;
 use clippy_utils::{get_item_name, get_parent_as_impl, is_lint_allowed, peel_ref_operators, sugg::Sugg};
 use if_chain::if_chain;
@@ -169,37 +168,29 @@ impl<'tcx> LateLintPass<'tcx> for LenZero {
             return;
         }
 
-        if let Some(let_chain) = LetChain::hir(expr) {
-            for if_let in let_chain.conds.iter().filter_map(|cond| {
-                if let IfOrIfLetInChain::IfLet(if_let) = cond {
-                    return Some(if_let);
-                }
-                None
-            }) {
-                if has_is_empty(cx, if_let.let_expr)
-                    && match if_let.let_pat.kind {
-                        PatKind::Slice([], _, []) => true,
-                        PatKind::Lit(lit) if is_empty_string(lit) => true,
-                        _ => false,
-                    }
-                {
-                    let mut applicability = Applicability::MachineApplicable;
-
-                    let lit1 = peel_ref_operators(cx, if_let.let_expr);
-                    let lit_str =
-                        Sugg::hir_with_context(cx, lit1, if_let.let_span.ctxt(), "_", &mut applicability).maybe_par();
-
-                    span_lint_and_sugg(
-                        cx,
-                        COMPARISON_TO_EMPTY,
-                        if_let.let_span,
-                        "comparison to empty slice using `if let`",
-                        "using `is_empty` is clearer and more explicit",
-                        format!("{lit_str}.is_empty()"),
-                        applicability,
-                    );
-                }
+        if let ExprKind::Let(lt) = expr.kind
+            && has_is_empty(cx, lt.init)
+            && match lt.pat.kind {
+                PatKind::Slice([], _, []) => true,
+                PatKind::Lit(lit) if is_empty_string(lit) => true,
+                _ => false,
             }
+        {
+            let mut applicability = Applicability::MachineApplicable;
+
+            let lit1 = peel_ref_operators(cx, lt.init);
+            let lit_str =
+                Sugg::hir_with_context(cx, lit1, lt.span.ctxt(), "_", &mut applicability).maybe_par();
+
+            span_lint_and_sugg(
+                cx,
+                COMPARISON_TO_EMPTY,
+                lt.span,
+                "comparison to empty slice using `if let`",
+                "using `is_empty` is clearer and more explicit",
+                format!("{lit_str}.is_empty()"),
+                applicability,
+            );
         }
 
         if let ExprKind::Binary(Spanned { node: cmp, .. }, left, right) = expr.kind {