Refactor lint categories into macro

Author: camsteffen

clippy_lints/src/lib.rs

@@ -47,6 +47,23 @@ use rustc_data_structures::fx::FxHashSet;
 use rustc_lint::LintId;
 use rustc_session::Session;
 
+macro_rules! clippy_lint_categories {
+    ($macro:path, $($tail:tt)*) => {
+        $macro!({
+            correctness:   Deny,
+            complexity:    Warn,
+            perf:          Warn,
+            style:         Warn,
+            pedantic:      Allow,
+            restriction:   Allow,
+            cargo:         Allow,
+            nursery:       Allow,
+            internal:      Allow,
+            internal_warn: Warn,
+        } $($tail)*);
+    };
+}
+
 /// Macro used to declare a Clippy lint.
 ///
 /// Every lint declaration consists of 4 parts:
@@ -92,60 +109,26 @@ use rustc_session::Session;
 /// }
 /// ```
 /// [lint_naming]: https://rust-lang.github.io/rfcs/0344-conventions-galore.html#lints
-#[macro_export]
-macro_rules! declare_clippy_lint {
-    { $(#[$attr:meta])* pub $name:tt, style, $description:tt } => {
-        declare_tool_lint! {
-            $(#[$attr])* pub clippy::$name, Warn, $description, report_in_external_macro: true
-        }
-    };
-    { $(#[$attr:meta])* pub $name:tt, correctness, $description:tt } => {
-        declare_tool_lint! {
-            $(#[$attr])* pub clippy::$name, Deny, $description, report_in_external_macro: true
-        }
-    };
-    { $(#[$attr:meta])* pub $name:tt, complexity, $description:tt } => {
-        declare_tool_lint! {
-            $(#[$attr])* pub clippy::$name, Warn, $description, report_in_external_macro: true
-        }
-    };
-    { $(#[$attr:meta])* pub $name:tt, perf, $description:tt } => {
-        declare_tool_lint! {
-            $(#[$attr])* pub clippy::$name, Warn, $description, report_in_external_macro: true
-        }
-    };
-    { $(#[$attr:meta])* pub $name:tt, pedantic, $description:tt } => {
-        declare_tool_lint! {
-            $(#[$attr])* pub clippy::$name, Allow, $description, report_in_external_macro: true
-        }
-    };
-    { $(#[$attr:meta])* pub $name:tt, restriction, $description:tt } => {
-        declare_tool_lint! {
-            $(#[$attr])* pub clippy::$name, Allow, $description, report_in_external_macro: true
-        }
-    };
-    { $(#[$attr:meta])* pub $name:tt, cargo, $description:tt } => {
-        declare_tool_lint! {
-            $(#[$attr])* pub clippy::$name, Allow, $description, report_in_external_macro: true
-        }
-    };
-    { $(#[$attr:meta])* pub $name:tt, nursery, $description:tt } => {
-        declare_tool_lint! {
-            $(#[$attr])* pub clippy::$name, Allow, $description, report_in_external_macro: true
-        }
-    };
-    { $(#[$attr:meta])* pub $name:tt, internal, $description:tt } => {
-        declare_tool_lint! {
-            $(#[$attr])* pub clippy::$name, Allow, $description, report_in_external_macro: true
-        }
-    };
-    { $(#[$attr:meta])* pub $name:tt, internal_warn, $description:tt } => {
-        declare_tool_lint! {
-            $(#[$attr])* pub clippy::$name, Warn, $description, report_in_external_macro: true
+macro_rules! declare_clippy_lint_macro {
+    ({ $($category:tt: $level:tt,)* } $d:tt) => {
+        macro_rules! declare_clippy_lint {
+            $(
+                ($d(#[$d meta:meta])* pub $d name:tt, $category, $d description:tt) => {
+                    declare_tool_lint! {
+                        $d(#[$d meta])*
+                        pub clippy::$d name,
+                        $level,
+                        $d description,
+                        report_in_external_macro: true
+                    }
+                };
+            )*
         }
     };
 }
 
+clippy_lint_categories!(declare_clippy_lint_macro, $);
+
 #[macro_export]
 macro_rules! sym {
     ( $($x:tt)* ) => { clippy_utils::sym!($($x)*) }