Add support for nightly only lints

Author: Jarcho

clippy_dev/src/new_lint.rs

@@ -163,26 +163,6 @@ fn to_camel_case(name: &str) -> String {
         .collect()
 }
 
-pub(crate) fn get_stabilization_version() -> String {
-    fn parse_manifest(contents: &str) -> Option<String> {
-        let version = contents
-            .lines()
-            .filter_map(|l| l.split_once('='))
-            .find_map(|(k, v)| (k.trim() == "version").then(|| v.trim()))?;
-        let Some(("0", version)) = version.get(1..version.len() - 1)?.split_once('.') else {
-            return None;
-        };
-        let (minor, patch) = version.split_once('.')?;
-        Some(format!(
-            "{}.{}.0",
-            minor.parse::<u32>().ok()?,
-            patch.parse::<u32>().ok()?
-        ))
-    }
-    let contents = fs::read_to_string("Cargo.toml").expect("Unable to read `Cargo.toml`");
-    parse_manifest(&contents).expect("Unable to find package version in `Cargo.toml`")
-}
-
 fn get_test_file_contents(lint_name: &str, header_commands: Option<&str>) -> String {
     let mut contents = format!(
         indoc! {"
@@ -327,13 +307,11 @@ fn get_lint_declaration(name_upper: &str, category: &str) -> String {
                 /// ```rust
                 /// // example code which does not raise clippy warning
                 /// ```
-                #[clippy::version = "{version}"]
                 pub {name_upper},
                 {category},
                 "default lint description"
             }}
         "#},
-        version = get_stabilization_version(),
         name_upper = name_upper,
         category = category,
     )

clippy_dev/src/update_lints.rs

@@ -491,7 +491,6 @@ fn declare_deprecated(name: &str, path: &Path, reason: &str) -> io::Result<()> {
 
     file.seek(SeekFrom::End(0))?;
 
-    let version = crate::new_lint::get_stabilization_version();
     let deprecation_reason = if reason == DEFAULT_DEPRECATION_REASON {
         "TODO"
     } else {
@@ -508,14 +507,13 @@ fn declare_deprecated(name: &str, path: &Path, reason: &str) -> io::Result<()> {
             ///
             /// ### Deprecation reason
             /// {}
-            #[clippy::version = \"{}\"]
+            #[clippy::version = \"nightly\"]
             pub {},
             \"{}\"
         }}
 
         ",
         deprecation_reason,
-        version,
         name,
         reason,
     )
@@ -588,17 +586,26 @@ struct Lint {
     group: String,
     desc: String,
     module: String,
+    has_version: bool,
     declaration_range: Range<usize>,
 }
 
 impl Lint {
     #[must_use]
-    fn new(name: &str, group: &str, desc: &str, module: &str, declaration_range: Range<usize>) -> Self {
+    fn new(
+        name: &str,
+        group: &str,
+        desc: &str,
+        module: &str,
+        has_version: bool,
+        declaration_range: Range<usize>,
+    ) -> Self {
         Self {
             name: name.to_lowercase(),
             group: group.into(),
             desc: remove_line_splices(desc),
             module: module.into(),
+            has_version,
             declaration_range,
         }
     }
@@ -657,20 +664,36 @@ impl RenamedLint {
 
 /// Generates the code for registering a group
 fn gen_lint_group_list<'a>(group_name: &str, lints: impl Iterator<Item = &'a Lint>) -> String {
-    let mut details: Vec<_> = lints.map(|l| (&l.module, l.name.to_uppercase())).collect();
-    details.sort_unstable();
+    let mut stable_count = 0usize;
+    let mut lints: Vec<_> = lints
+        .inspect(|l| {
+            if l.has_version {
+                stable_count += 1;
+            }
+        })
+        .map(|l| (!l.has_version, &l.module, l.name.to_uppercase()))
+        .collect();
+    lints.sort_unstable();
 
     let mut output = GENERATED_FILE_COMMENT.to_string();
-
+    let _ = write!(output, "{{\n    let lints: [LintId; {}] = [\n", lints.len());
+    for (_, module, name) in &lints {
+        let _ = writeln!(output, "        LintId::of({}::{}),", module, name);
+    }
+    output.push_str("    ];\n");
+    if stable_count != lints.len() {
+        output.push_str("    let lints = if sess.opts.unstable_features.is_nightly_build() {\n");
+        output.push_str("        lints.as_slice()\n");
+        output.push_str("    } else {\n");
+        let _ = writeln!(output, "        &lints[..{}]", stable_count);
+        output.push_str("    };\n");
+    }
     let _ = writeln!(
         output,
-        "store.register_group(true, \"clippy::{0}\", Some(\"clippy_{0}\"), vec![",
+        "    store.register_group(true, \"clippy::{0}\", Some(\"clippy_{0}\"), lints.to_vec());",
         group_name
     );
-    for (module, name) in details {
-        let _ = writeln!(output, "    LintId::of({}::{}),", module, name);
-    }
-    output.push_str("])\n");
+    output.push_str("}");
 
     output
 }
@@ -858,21 +881,22 @@ fn parse_contents(contents: &str, module: &str, lints: &mut Vec<Lint>) {
             .filter(|t| !matches!(t.token_kind, TokenKind::Whitespace | TokenKind::LineComment { .. }));
         // matches `!{`
         match_tokens!(iter, Bang OpenBrace);
-        match iter.next() {
+        let has_version = match iter.next() {
             // #[clippy::version = "version"] pub
             Some(LintDeclSearchResult {
                 token_kind: TokenKind::Pound,
                 ..
             }) => {
                 match_tokens!(iter, OpenBracket Ident Colon Colon Ident Eq Literal{..} CloseBracket Ident);
+                true
             },
             // pub
             Some(LintDeclSearchResult {
                 token_kind: TokenKind::Ident,
                 ..
-            }) => (),
+            }) => false,
             _ => continue,
-        }
+        };
 
         let (name, group, desc) = match_tokens!(
             iter,
@@ -890,7 +914,7 @@ fn parse_contents(contents: &str, module: &str, lints: &mut Vec<Lint>) {
             ..
         }) = iter.next()
         {
-            lints.push(Lint::new(name, group, desc, module, start..range.end));
+            lints.push(Lint::new(name, group, desc, module, has_version, start..range.end));
         }
     }
 }