Skip to content

cargo dev bless doesn't work #6757

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Y-Nak opened this issue Feb 18, 2021 · 2 comments · Fixed by #6774
Closed

cargo dev bless doesn't work #6757

Y-Nak opened this issue Feb 18, 2021 · 2 comments · Fixed by #6774

Comments

@Y-Nak
Copy link
Contributor

Y-Nak commented Feb 18, 2021

cargo dev bless command seems not to work since the version of compiletest-rs is updated in #6743.

I think this is because the updated compiletest joins stage_id to output file names like zero_div_zero.stage-id.stderr, while bless.rs doesn't take it into account. (I don't know why the former version of compiletest doesn't join it although the codes related to file names seem unchanged).

I suppose we could explicitly specify config.stage_id = "" in here as a quickfix.

ref: #5394

@Y-Nak Y-Nak changed the title cargo dev bless doesn't work. cargo dev bless doesn't work Feb 18, 2021
@camsteffen
Copy link
Contributor

We may want to just migrate to the bless feature that is now available in compiletest itself.

@Y-Nak
Copy link
Contributor Author

Y-Nak commented Feb 22, 2021

Yeah, it's most desirable, but I suppose it's worth doing a quick-fix since it seems the transition to new bless needs more discussion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants