Skip to content

useless_format lint gives a wrong example for "Good" #6844

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ColinFinck opened this issue Mar 4, 2021 · 1 comment · Fixed by #6854
Closed

useless_format lint gives a wrong example for "Good" #6844

ColinFinck opened this issue Mar 4, 2021 · 1 comment · Fixed by #6854
Assignees
Labels
A-documentation Area: Adding or improving documentation good-first-issue These issues are a good way to get started with Clippy

Comments

@ColinFinck
Copy link

ColinFinck commented Mar 4, 2021

The description of the useless_format lint gives the following "Bad" and "Good" examples:

/// // Bad
/// # let foo = "foo";
/// format!("{}", foo);
///
/// // Good
/// format!("foo");

However, the "Good" example is something that is also not accepted by the useless_format lint.

@camsteffen camsteffen added A-documentation Area: Adding or improving documentation good-first-issue These issues are a good way to get started with Clippy labels Mar 4, 2021
@mgacek8
Copy link
Contributor

mgacek8 commented Mar 5, 2021

@rustbot claim

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-documentation Area: Adding or improving documentation good-first-issue These issues are a good way to get started with Clippy
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants