From aa2f48b09ddc4a3ed50005cefab9cdd26c9cd8bb Mon Sep 17 00:00:00 2001 From: cerdelen Date: Sun, 13 Apr 2025 15:35:18 +0200 Subject: [PATCH] Change Test for Issue 14422 (Cognitive Complexity lowered through multiple returns) to test it does'nt regress to false negative --- tests/ui/cognitive_complexity.rs | 4 +++- tests/ui/cognitive_complexity.stderr | 18 +++++++++++++++++- 2 files changed, 20 insertions(+), 2 deletions(-) diff --git a/tests/ui/cognitive_complexity.rs b/tests/ui/cognitive_complexity.rs index 4f6dd35e8cbb..8080c6775e0b 100644 --- a/tests/ui/cognitive_complexity.rs +++ b/tests/ui/cognitive_complexity.rs @@ -454,15 +454,17 @@ mod issue9300 { } } -#[clippy::cognitive_complexity = "2"] +#[clippy::cognitive_complexity = "1"] mod issue14422 { fn foo() { + //~^ cognitive_complexity for _ in 0..10 { println!("hello there"); } } fn bar() { + //~^ cognitive_complexity for _ in 0..10 { println!("hello there"); } diff --git a/tests/ui/cognitive_complexity.stderr b/tests/ui/cognitive_complexity.stderr index 2be56ff88b34..67ef4e5655bd 100644 --- a/tests/ui/cognitive_complexity.stderr +++ b/tests/ui/cognitive_complexity.stderr @@ -160,5 +160,21 @@ LL | pub async fn async_method() { | = help: you could split it up into multiple smaller functions -error: aborting due to 20 previous errors +error: the function has a cognitive complexity of (2/1) + --> tests/ui/cognitive_complexity.rs:459:8 + | +LL | fn foo() { + | ^^^ + | + = help: you could split it up into multiple smaller functions + +error: the function has a cognitive complexity of (2/1) + --> tests/ui/cognitive_complexity.rs:466:8 + | +LL | fn bar() { + | ^^^ + | + = help: you could split it up into multiple smaller functions + +error: aborting due to 22 previous errors