Skip to content

Commit a32d8f2

Browse files
est31Mark-Simulacrum
authored andcommitted
Changes reflecting the new placeholder policy for stabilizations
1 parent 6db149a commit a32d8f2

File tree

2 files changed

+12
-1
lines changed

2 files changed

+12
-1
lines changed

src/release/backporting.md

+1
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,7 @@ Getting a PR backported to the beta branch involves the following process:
2222
1. Create a local branch off the `beta` branch.
2323
2. Cherry-pick all of the PRs that have both [`beta-nominated` and `beta-accepted`][nominated-plus-accepted] labels.
2424
It is usually preferred to not include PRs that have not been merged in case there are any last minute changes, or it fails when running the full CI tests.
25+
3. Run `./x.py run replace-version-placeholder` and if there were any changes, put them into a new commit.
2526
3. (Recommended) Run some tests locally.
2627
It is not uncommon that the backports may not apply cleanly, or the UI tests need to be re-blessed if there are differences in the output.
2728
4. Open a PR **against the beta branch** with a title that starts with `[beta]` (so reviewers can see its specialness).

src/release/process.md

+11-1
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,13 @@ time, but make sure the stable promotion lands first.
2525
```
2626

2727
Once that's done, send a PR to the freshly created beta branch of rust-lang/rust
28-
which updates `src/ci/channel` to `beta`.
28+
with two commits:
29+
30+
* The changes caused by running `./x.py run replace-version-placeholder`
31+
* An update of `src/ci/channel` to `beta`
32+
33+
The version placeholder replacement changes must be in a separate commit so
34+
that they can be cherry picked to the master branch.
2935

3036
Also send a PR to rust-lang/rust targeting the new stable branch making the
3137
following changes:
@@ -49,6 +55,10 @@ credentials][awscli] and run this command from the [simpleinfra] repository:
4955

5056
Send a PR to the master branch to:
5157

58+
- Cherry pick the commit that ran `./x.py run replace-version-placeholder`
59+
from the now merged beta branch PR. Do not re-run the tool as there might
60+
have been other stabilizations on master which were not included in the
61+
branched beta, so may not be attributed to the current release.
5262
- Run `./x.py run src/tools/bump-stage0` to update the bootstrap compiler to
5363
the beta you created yesterday.
5464

0 commit comments

Comments
 (0)