Skip to content

Commit 246de45

Browse files
committed
Apply rust-logo class only on default logo
Also replace ' with " in rustdoc template
1 parent d594910 commit 246de45

File tree

3 files changed

+28
-18
lines changed

3 files changed

+28
-18
lines changed

src/librustdoc/html/templates/page.html

+14-18
Original file line numberDiff line numberDiff line change
@@ -74,30 +74,26 @@
7474
{{- layout.external_html.before_content | safe -}}
7575
<nav class="sidebar"> {#- -#}
7676
<div class="sidebar-menu" role="button">&#9776;</div> {#- -#}
77-
<a class="sidebar-logo" href='{{page.root_path | safe}}{{krate_with_trailing_slash | safe}}index.html'> {#- -#}
78-
<div class='logo-container rust-logo'> {#- -#}
79-
<img src='
80-
{%- if layout.logo -%}
81-
{{layout.logo}}
82-
{%- else -%}
83-
{{static_root_path | safe}}rust-logo{{page.resource_suffix}}.png
84-
{%- endif -%}
85-
' alt='logo'> {#- -#}
86-
</div> {#- -#}
77+
<a class="sidebar-logo" href="{{page.root_path | safe}}{{krate_with_trailing_slash | safe}}index.html"> {#- -#}
78+
<div class="logo-container"> {#- -#}
79+
{%- if layout.logo -%}
80+
<img src="{{layout.logo}}" alt="logo"> {#- -#}
81+
{%- else -%}
82+
<img class="rust-logo" src="{{static_root_path | safe}}rust-logo{{page.resource_suffix}}.png" alt="logo"> {#- -#}
83+
{%- endif -%}
84+
</div>
8785
</a> {#- -#}
8886
{{- sidebar | safe -}}
8987
</nav> {#- -#}
9088
<main> {#- -#}
9189
<div class="width-limiter"> {#- -#}
9290
<div class="sub-container"> {#- -#}
93-
<a class="sub-logo-container rust-logo" href='{{page.root_path | safe}}{{krate_with_trailing_slash | safe}}index.html'> {#- -#}
94-
<img src='
95-
{%- if layout.logo -%}
96-
{{layout.logo}}
97-
{%- else -%}
98-
{{static_root_path | safe}}rust-logo{{page.resource_suffix}}.png
99-
{%- endif -%}
100-
' alt='logo'> {#- -#}
91+
<a class="sub-logo-container" href="{{page.root_path | safe}}{{krate_with_trailing_slash | safe}}index.html"> {#- -#}
92+
{%- if layout.logo -%}
93+
<img src="{{layout.logo}}" alt="logo">
94+
{%- else -%}
95+
<img class="rust-logo" src="{{static_root_path | safe}}rust-logo{{page.resource_suffix}}.png" alt="logo">
96+
{%- endif -%}
10197
</a> {#- -#}
10298
<nav class="sub"> {#- -#}
10399
<div class="theme-picker"> {#- -#}
+4
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,4 @@
1+
// Note: this test is paired with logo-class.rs.
2+
// @has logo_class_default/struct.SomeStruct.html '//*[@class="logo-container"]/img[@class="rust-logo"]' ''
3+
// @has logo_class_default/struct.SomeStruct.html '//*[@class="sub-logo-container"]/img[@class="rust-logo"]' ''
4+
pub struct SomeStruct;

src/test/rustdoc/logo-class.rs

+10
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,10 @@
1+
#![doc(html_logo_url =
2+
"https://raw.githubusercontent.com/sagebind/isahc/master/media/isahc.svg.png")]
3+
// Note: this test is paired with logo-class-default.rs.
4+
5+
// @has logo_class/struct.SomeStruct.html '//*[@class="logo-container"]/img[@src="https://raw.githubusercontent.com/sagebind/isahc/master/media/isahc.svg.png"]' ''
6+
// @!has logo_class/struct.SomeStruct.html '//*[@class="logo-container"]/img[@class="rust-logo"]' ''
7+
//
8+
// @has logo_class/struct.SomeStruct.html '//*[@class="sub-logo-container"]/img[@src="https://raw.githubusercontent.com/sagebind/isahc/master/media/isahc.svg.png"]' ''
9+
// @!has logo_class/struct.SomeStruct.html '//*[@class="sub-logo-container"]/img[@class="rust-logo"]' ''
10+
pub struct SomeStruct;

0 commit comments

Comments
 (0)