change approach to prevent interleaving compiletest message

Author: pietroalbini

Diff for: src/bootstrap/render_tests.rs

@@ -7,7 +7,7 @@
 //! to reimplement all the rendering logic in this module because of that.
 
 use crate::builder::Builder;
-use std::io::{BufRead, BufReader, Cursor, Write};
+use std::io::{BufRead, BufReader, Write};
 use std::process::{ChildStdout, Command, Stdio};
 use std::time::Duration;
 use yansi_term::Color;
@@ -43,7 +43,6 @@ pub(crate) fn try_run_tests(builder: &Builder<'_>, cmd: &mut Command) -> bool {
 
 fn run_tests(builder: &Builder<'_>, cmd: &mut Command) -> bool {
     cmd.stdout(Stdio::piped());
-    cmd.stderr(Stdio::piped());
 
     builder.verbose(&format!("running: {cmd:?}"));
 
@@ -62,10 +61,6 @@ fn run_tests(builder: &Builder<'_>, cmd: &mut Command) -> bool {
         );
     }
 
-    // Show the stderr emitted by the test runner at the end. As of 2023-03-02 this is only the
-    // message at the end of a failed compiletest run.
-    std::io::copy(&mut Cursor::new(&result.stderr), &mut std::io::stderr().lock()).unwrap();
-
     result.status.success()
 }
 

Diff for: src/tools/compiletest/src/main.rs

@@ -422,7 +422,7 @@ pub fn run_tests(config: Config) {
             // easy to miss which tests failed, and as such fail to reproduce
             // the failure locally.
 
-            eprintln!(
+            println!(
                 "Some tests failed in compiletest suite={}{} mode={} host={} target={}",
                 config.suite,
                 config.compare_mode.map(|c| format!(" compare_mode={:?}", c)).unwrap_or_default(),