Skip to content

Commit 4b740ac

Browse files
committed
Add FIXME note about storing &'tcx str
1 parent 7a46a4f commit 4b740ac

File tree

1 file changed

+5
-0
lines changed

1 file changed

+5
-0
lines changed

compiler/rustc_lint/src/builtin.rs

+5
Original file line numberDiff line numberDiff line change
@@ -2596,6 +2596,11 @@ declare_lint! {
25962596
}
25972597

25982598
pub struct ClashingExternDeclarations {
2599+
/// Map of function symbol name to the first-seen hir id for that symbol name.. If seen_decls
2600+
/// contains an entry for key K, it means a symbol with name K has been seen by this lint and
2601+
/// the symbol should be reported as a clashing declaration.
2602+
// FIXME: Technically, we could just store a &'tcx str here without issue; however, the
2603+
// `impl_lint_pass` macro doesn't currently support lints parametric over a lifetime.
25992604
seen_decls: FxHashMap<String, HirId>,
26002605
}
26012606

0 commit comments

Comments
 (0)