clippy: env! invocations can't be b"" literals

davidtwco · davidtwco · commit 516a56581e4c · 2023-07-25T11:56:54.000+01:00
Signed-off-by: David Wood &lt;david@davidtw.co&gt;
diff --git a/src/tools/clippy/clippy_lints/src/strings.rs b/src/tools/clippy/clippy_lints/src/strings.rs
@@ -328,7 +328,7 @@ impl<'tcx> LateLintPass<'tcx> for StringLitAsBytes {
                     {
                         // Don't lint. Byte strings produce `&[u8; N]` whereas `as_bytes()` produces
                         // `&[u8]`. This change would prevent matching with different sized slices.
-                    } else {
+                    } else if !callsite.starts_with("env!") {
                         span_lint_and_sugg(
                             cx,
                             STRING_LIT_AS_BYTES,

Original file line number	Diff line number	Diff line change
`@@ -328,7 +328,7 @@ impl<'tcx> LateLintPass<'tcx> for StringLitAsBytes {`
`328`	`328`	`{`
`329`	`329`	// Don't lint. Byte strings produce `&[u8; N]` whereas `as_bytes()` produces
`330`	`330`	// `&[u8]`. This change would prevent matching with different sized slices.
`331`		`- } else {`
	`331`	`+ } else if !callsite.starts_with("env!") {`
`332`	`332`	`span_lint_and_sugg(`
`333`	`333`	`cx,`
`334`	`334`	`STRING_LIT_AS_BYTES,`