Skip to content

Commit 64a68ae

Browse files
author
Tor Hovland
committed
No longer need to add attrs to ImportSource.
1 parent c975fe2 commit 64a68ae

File tree

4 files changed

+17
-10
lines changed

4 files changed

+17
-10
lines changed

src/librustdoc/clean/inline.rs

-1
Original file line numberDiff line numberDiff line change
@@ -477,7 +477,6 @@ fn build_module(
477477
}],
478478
},
479479
did: None,
480-
attrs: None,
481480
},
482481
true,
483482
)),

src/librustdoc/clean/types.rs

-1
Original file line numberDiff line numberDiff line change
@@ -2081,7 +2081,6 @@ crate enum ImportKind {
20812081
crate struct ImportSource {
20822082
crate path: Path,
20832083
crate did: Option<DefId>,
2084-
crate attrs: Option<Box<Attributes>>,
20852084
}
20862085

20872086
#[derive(Clone, Debug)]

src/librustdoc/clean/utils.rs

+4-4
Original file line numberDiff line numberDiff line change
@@ -468,10 +468,10 @@ crate fn register_res(cx: &mut DocContext<'_>, res: Res) -> DefId {
468468
}
469469

470470
crate fn resolve_use_source(cx: &mut DocContext<'_>, path: Path) -> ImportSource {
471-
let did = if path.res.opt_def_id().is_none() { None } else { Some(register_res(cx, path.res)) };
472-
let attrs = did.map(|did| Box::new(cx.tcx.get_attrs(did).clean(cx)));
473-
474-
ImportSource { did, path, attrs }
471+
ImportSource {
472+
did: if path.res.opt_def_id().is_none() { None } else { Some(register_res(cx, path.res)) },
473+
path,
474+
}
475475
}
476476

477477
crate fn enter_impl_trait<F, R>(cx: &mut DocContext<'_>, f: F) -> R

src/librustdoc/html/render/print_item.rs

+13-4
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@ use rustc_data_structures::fx::FxHashMap;
44
use rustc_hir as hir;
55
use rustc_hir::def::CtorKind;
66
use rustc_hir::def_id::DefId;
7+
use rustc_middle::dep_graph::DepContext;
78
use rustc_middle::middle::stability;
89
use rustc_middle::ty::TyCtxt;
910
use rustc_span::hygiene::MacroKind;
@@ -282,11 +283,19 @@ fn item_module(w: &mut Buffer, cx: &Context<'_>, item: &clean::Item, items: &[cl
282283
}
283284

284285
clean::ImportItem(ref import) => {
285-
let (stab, stab_tags) = if let (Some(def_id), Some(attrs)) =
286-
(import.source.did, import.source.attrs.clone())
287-
{
286+
let (stab, stab_tags) = if let Some(import_def_id) = import.source.did {
287+
let import_attrs = Box::new(clean::Attributes::from_ast(
288+
cx.tcx().sess().diagnostic(),
289+
cx.tcx().get_attrs(import_def_id),
290+
None,
291+
));
292+
288293
// Just need an item with the correct def_id and attrs
289-
let import_item = clean::Item { def_id, attrs, ..myitem.clone() };
294+
let import_item = clean::Item {
295+
def_id: import_def_id,
296+
attrs: import_attrs,
297+
..myitem.clone()
298+
};
290299

291300
let stab = import_item.stability_class(cx.tcx());
292301
let stab_tags = Some(extra_info_tags(&import_item, item, cx.tcx()));

0 commit comments

Comments
 (0)