Skip to content

Commit 83f081f

Browse files
committed
Remove unstable Result::into_ok_or_err
1 parent 9c20b2a commit 83f081f

File tree

6 files changed

+8
-59
lines changed

6 files changed

+8
-59
lines changed

Diff for: compiler/rustc_codegen_gcc/patches/0024-core-Disable-portable-simd-test.patch

-1
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,6 @@ index 06c7be0..359e2e7 100644
1414
@@ -75,7 +75,6 @@
1515
#![feature(never_type)]
1616
#![feature(unwrap_infallible)]
17-
#![feature(result_into_ok_or_err)]
1817
-#![feature(portable_simd)]
1918
#![feature(ptr_metadata)]
2019
#![feature(once_cell)]

Diff for: compiler/rustc_transmute/src/layout/tree.rs

+7-6
Original file line numberDiff line numberDiff line change
@@ -86,17 +86,18 @@ where
8686
F: Fn(D) -> bool,
8787
{
8888
match self {
89-
Self::Seq(elts) => elts
90-
.into_iter()
91-
.map(|elt| elt.prune(f))
92-
.try_fold(Tree::unit(), |elts, elt| {
89+
Self::Seq(elts) => match elts.into_iter().map(|elt| elt.prune(f)).try_fold(
90+
Tree::unit(),
91+
|elts, elt| {
9392
if elt == Tree::uninhabited() {
9493
Err(Tree::uninhabited())
9594
} else {
9695
Ok(elts.then(elt))
9796
}
98-
})
99-
.into_ok_or_err(),
97+
},
98+
) {
99+
Err(node) | Ok(node) => node,
100+
},
100101
Self::Alt(alts) => alts
101102
.into_iter()
102103
.map(|alt| alt.prune(f))

Diff for: compiler/rustc_transmute/src/lib.rs

+1-8
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,4 @@
1-
#![feature(
2-
alloc_layout_extra,
3-
control_flow_enum,
4-
decl_macro,
5-
iterator_try_reduce,
6-
never_type,
7-
result_into_ok_or_err
8-
)]
1+
#![feature(alloc_layout_extra, control_flow_enum, decl_macro, iterator_try_reduce, never_type)]
92
#![allow(dead_code, unused_variables)]
103

114
#[macro_use]

Diff for: library/core/src/result.rs

-34
Original file line numberDiff line numberDiff line change
@@ -1771,40 +1771,6 @@ impl<T, E> Result<Result<T, E>, E> {
17711771
}
17721772
}
17731773

1774-
impl<T> Result<T, T> {
1775-
/// Returns the [`Ok`] value if `self` is `Ok`, and the [`Err`] value if
1776-
/// `self` is `Err`.
1777-
///
1778-
/// In other words, this function returns the value (the `T`) of a
1779-
/// `Result<T, T>`, regardless of whether or not that result is `Ok` or
1780-
/// `Err`.
1781-
///
1782-
/// This can be useful in conjunction with APIs such as
1783-
/// [`Atomic*::compare_exchange`], or [`slice::binary_search`], but only in
1784-
/// cases where you don't care if the result was `Ok` or not.
1785-
///
1786-
/// [`Atomic*::compare_exchange`]: crate::sync::atomic::AtomicBool::compare_exchange
1787-
///
1788-
/// # Examples
1789-
///
1790-
/// ```
1791-
/// #![feature(result_into_ok_or_err)]
1792-
/// let ok: Result<u32, u32> = Ok(3);
1793-
/// let err: Result<u32, u32> = Err(4);
1794-
///
1795-
/// assert_eq!(ok.into_ok_or_err(), 3);
1796-
/// assert_eq!(err.into_ok_or_err(), 4);
1797-
/// ```
1798-
#[inline]
1799-
#[unstable(feature = "result_into_ok_or_err", reason = "newly added", issue = "82223")]
1800-
pub const fn into_ok_or_err(self) -> T {
1801-
match self {
1802-
Ok(v) => v,
1803-
Err(v) => v,
1804-
}
1805-
}
1806-
}
1807-
18081774
// This is a separate function to reduce the code size of the methods
18091775
#[cfg(not(feature = "panic_immediate_abort"))]
18101776
#[inline(never)]

Diff for: library/core/tests/lib.rs

-1
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,6 @@
7575
#![feature(const_pin)]
7676
#![feature(never_type)]
7777
#![feature(unwrap_infallible)]
78-
#![feature(result_into_ok_or_err)]
7978
#![feature(pointer_byte_offsets)]
8079
#![feature(portable_simd)]
8180
#![feature(ptr_metadata)]

Diff for: library/core/tests/result.rs

-9
Original file line numberDiff line numberDiff line change
@@ -95,15 +95,6 @@ fn test_unwrap_or() {
9595
assert_eq!(ok_err.unwrap_or(50), 50);
9696
}
9797

98-
#[test]
99-
fn test_ok_or_err() {
100-
let ok: Result<isize, isize> = Ok(100);
101-
let err: Result<isize, isize> = Err(200);
102-
103-
assert_eq!(ok.into_ok_or_err(), 100);
104-
assert_eq!(err.into_ok_or_err(), 200);
105-
}
106-
10798
#[test]
10899
fn test_unwrap_or_else() {
109100
fn handler(msg: &'static str) -> isize {

0 commit comments

Comments
 (0)