Skip to content

Commit 8761f79

Browse files
committed
Remove deriving(ToStr)
This has been superseded by deriving(Show). cc #9806
1 parent b78b749 commit 8761f79

File tree

9 files changed

+27
-159
lines changed

9 files changed

+27
-159
lines changed

src/libcollections/btree.rs

+4-4
Original file line numberDiff line numberDiff line change
@@ -405,8 +405,8 @@ impl<K: fmt::Show + TotalOrd, V: fmt::Show> fmt::Show for Leaf<K, V> {
405405
///Returns a string representation of a Leaf.
406406
fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result {
407407
for (i, s) in self.elts.iter().enumerate() {
408-
if i != 0 { if_ok!(write!(f.buf, " // ")) }
409-
if_ok!(write!(f.buf, "{}", *s))
408+
if i != 0 { try!(write!(f.buf, " // ")) }
409+
try!(write!(f.buf, "{}", *s))
410410
}
411411
Ok(())
412412
}
@@ -626,8 +626,8 @@ impl<K: fmt::Show + TotalOrd, V: fmt::Show> fmt::Show for Branch<K, V> {
626626
///Returns a string representation of a Branch.
627627
fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result {
628628
for (i, s) in self.elts.iter().enumerate() {
629-
if i != 0 { if_ok!(write!(f.buf, " // ")) }
630-
if_ok!(write!(f.buf, "{}", *s))
629+
if i != 0 { try!(write!(f.buf, " // ")) }
630+
try!(write!(f.buf, "{}", *s))
631631
}
632632
write!(f.buf, " // rightmost child: ({}) ", *self.rightmost_child)
633633
}

src/libcollections/lru_cache.rs

+7-7
Original file line numberDiff line numberDiff line change
@@ -222,24 +222,24 @@ impl<A: fmt::Show + Hash + Eq, B: fmt::Show> fmt::Show for LruCache<A, B> {
222222
/// Return a string that lists the key-value pairs from most-recently
223223
/// used to least-recently used.
224224
fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result {
225-
if_ok!(write!(f.buf, r"\{"));
225+
try!(write!(f.buf, r"\{"));
226226
let mut cur = self.head;
227227
for i in range(0, self.len()) {
228-
if i > 0 { if_ok!(write!(f.buf, ", ")) }
228+
if i > 0 { try!(write!(f.buf, ", ")) }
229229
unsafe {
230230
cur = (*cur).next;
231231
match (*cur).key {
232232
// should never print nil
233-
None => if_ok!(write!(f.buf, "nil")),
234-
Some(ref k) => if_ok!(write!(f.buf, "{}", *k)),
233+
None => try!(write!(f.buf, "nil")),
234+
Some(ref k) => try!(write!(f.buf, "{}", *k)),
235235
}
236236
}
237-
if_ok!(write!(f.buf, ": "));
237+
try!(write!(f.buf, ": "));
238238
unsafe {
239239
match (*cur).value {
240240
// should never print nil
241-
None => if_ok!(write!(f.buf, "nil")),
242-
Some(ref value) => if_ok!(write!(f.buf, "{}", *value)),
241+
None => try!(write!(f.buf, "nil")),
242+
Some(ref value) => try!(write!(f.buf, "{}", *value)),
243243
}
244244
}
245245
}

src/libextra/url.rs

+9-9
Original file line numberDiff line numberDiff line change
@@ -803,25 +803,25 @@ impl fmt::Show for Url {
803803
* result in just "http://somehost.com".
804804
*/
805805
fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result {
806-
if_ok!(write!(f.buf, "{}:", self.scheme));
806+
try!(write!(f.buf, "{}:", self.scheme));
807807

808808
if !self.host.is_empty() {
809-
if_ok!(write!(f.buf, "//"));
809+
try!(write!(f.buf, "//"));
810810
match self.user {
811-
Some(ref user) => if_ok!(write!(f.buf, "{}", *user)),
811+
Some(ref user) => try!(write!(f.buf, "{}", *user)),
812812
None => {}
813813
}
814814
match self.port {
815-
Some(ref port) => if_ok!(write!(f.buf, "{}:{}", self.host,
815+
Some(ref port) => try!(write!(f.buf, "{}:{}", self.host,
816816
*port)),
817-
None => if_ok!(write!(f.buf, "{}", self.host)),
817+
None => try!(write!(f.buf, "{}", self.host)),
818818
}
819819
}
820820

821-
if_ok!(write!(f.buf, "{}", self.path));
821+
try!(write!(f.buf, "{}", self.path));
822822

823823
if !self.query.is_empty() {
824-
if_ok!(write!(f.buf, "?{}", query_to_str(&self.query)));
824+
try!(write!(f.buf, "?{}", query_to_str(&self.query)));
825825
}
826826

827827
match self.fragment {
@@ -834,9 +834,9 @@ impl fmt::Show for Url {
834834

835835
impl fmt::Show for Path {
836836
fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result {
837-
if_ok!(write!(f.buf, "{}", self.path));
837+
try!(write!(f.buf, "{}", self.path));
838838
if !self.query.is_empty() {
839-
if_ok!(write!(f.buf, "?{}", self.query))
839+
try!(write!(f.buf, "?{}", self.query))
840840
}
841841

842842
match self.fragment {

src/libsyntax/abi.rs

+1-1
Original file line numberDiff line numberDiff line change
@@ -281,7 +281,7 @@ impl fmt::Show for Abi {
281281

282282
impl fmt::Show for AbiSet {
283283
fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result {
284-
if_ok!(write!(f.buf, "\""));
284+
try!(write!(f.buf, "\""));
285285
let mut first = true;
286286
self.each(|abi| {
287287
if first { first = false; }

src/libsyntax/crateid.rs

+1-1
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ pub struct CrateId {
3030

3131
impl fmt::Show for CrateId {
3232
fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result {
33-
if_ok!(write!(f.buf, "{}", self.path));
33+
try!(write!(f.buf, "{}", self.path));
3434
let version = match self.version {
3535
None => "0.0",
3636
Some(ref version) => version.as_slice(),

src/libsyntax/ext/deriving/mod.rs

-2
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,6 @@ pub mod encodable;
2727
pub mod decodable;
2828
pub mod hash;
2929
pub mod rand;
30-
pub mod to_str;
3130
pub mod show;
3231
pub mod zero;
3332
pub mod default;
@@ -85,7 +84,6 @@ pub fn expand_meta_deriving(cx: &mut ExtCtxt,
8584

8685
"Rand" => expand!(rand::expand_deriving_rand),
8786

88-
"ToStr" => expand!(to_str::expand_deriving_to_str),
8987
"Show" => expand!(show::expand_deriving_show),
9088

9189
"Zero" => expand!(zero::expand_deriving_zero),

src/libsyntax/ext/deriving/to_str.rs

-132
This file was deleted.

src/libuuid/lib.rs

+3-3
Original file line numberDiff line numberDiff line change
@@ -64,15 +64,15 @@ Examples of string representations:
6464
extern crate test;
6565
extern crate serialize;
6666

67-
use std::cast::{transmute,transmute_copy};
6867
use std::cast::{transmute,transmute_copy};
6968
use std::char::Char;
70-
use std::cmp::Eq;
71-
use std::cmp::Eq;
7269
use std::fmt;
7370
use std::hash::{Hash, sip};
7471
use std::num::FromStrRadix;
7572
use std::rand::Rng;
73+
use std::rand;
74+
use std::str;
75+
use std::vec;
7676

7777
use serialize::{Encoder, Encodable, Decoder, Decodable};
7878

src/test/run-pass/super-fast-paren-parsing.rs

+2
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,8 @@
88
// option. This file may not be copied, modified, or distributed
99
// except according to those terms.
1010

11+
// ignore-pretty
12+
1113
static a: int =
1214
(((((((((((((((((((((((((((((((((((((((((((((((((((
1315
(((((((((((((((((((((((((((((((((((((((((((((((((((

0 commit comments

Comments
 (0)