Skip to content

Commit 8e2631b

Browse files
authored
Rollup merge of #135146 - Zalathar:anyhow-backtrace, r=jieyouxu
Don't enable anyhow's `backtrace` feature in opt-dist As of the stabilization of `std::backtrace` in Rust 1.65, this package flag has no effect other than to enable an unused dependency on the `backtrace` crate. (See <https://github.com/dtolnay/anyhow/blob/af0937ef72fbaf9784a6c991e029738728d025e2/Cargo.toml#L18-L23>.) While the presence of this feature in opt-dist doesn't cause other tools (which use anyhow) to actually *build* backtrace, it does affect the global crate graph used for dependency version resolution. After removing this feature, we can use `cargo tree --invert --package backtrace` to see that the only remaining reverse-dependency of backtrace is `color-eyre`, which is used by `ui_test`.
2 parents c31a4b9 + 85e0d42 commit 8e2631b

File tree

2 files changed

+1
-4
lines changed

2 files changed

+1
-4
lines changed

Cargo.lock

-3
Original file line numberDiff line numberDiff line change
@@ -185,9 +185,6 @@ name = "anyhow"
185185
version = "1.0.95"
186186
source = "registry+https://github.com/rust-lang/crates.io-index"
187187
checksum = "34ac096ce696dc2fcabef30516bb13c0a68a11d30131d3df6f04711467681b04"
188-
dependencies = [
189-
"backtrace",
190-
]
191188

192189
[[package]]
193190
name = "ar_archive_writer"

src/tools/opt-dist/Cargo.toml

+1-1
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ edition = "2021"
77
build_helper = { path = "../../build_helper" }
88
env_logger = "0.11"
99
log = "0.4"
10-
anyhow = { version = "1", features = ["backtrace"] }
10+
anyhow = "1"
1111
humantime = "2"
1212
humansize = "2"
1313
sysinfo = { version = "0.31.2", default-features = false, features = ["disk"] }

0 commit comments

Comments
 (0)