Skip to content

Commit ab03c56

Browse files
committed
Explicitly disable preinline during pgo-use test
We previously used -Os to disable this pass, but since https://reviews.llvm.org/D91673 this no longer works. Explicitly disable it using -Cllvm-args instead.
1 parent 9a8acea commit ab03c56

File tree

1 file changed

+4
-5
lines changed
  • src/test/run-make-fulldeps/pgo-use

1 file changed

+4
-5
lines changed

src/test/run-make-fulldeps/pgo-use/Makefile

+4-5
Original file line numberDiff line numberDiff line change
@@ -12,12 +12,11 @@
1212
# `else` branch. Accordingly, we expect the function that is never called to
1313
# be marked as cold.
1414
#
15-
# The program is compiled with `-Copt-level=s` because this setting disables
16-
# LLVM's pre-inlining pass (i.e. a pass that does some inlining before it adds
17-
# the profiling instrumentation). Disabling this pass leads to rather
18-
# predictable IR which we need for this test to be stable.
15+
# Disable the pre-inlining pass (i.e. a pass that does some inlining before
16+
# it adds the profiling instrumentation). Disabling this pass leads to
17+
# rather predictable IR which we need for this test to be stable.
1918

20-
COMMON_FLAGS=-Copt-level=s -Ccodegen-units=1
19+
COMMON_FLAGS=-Copt-level=2 -Ccodegen-units=1 -Cllvm-args=-disable-preinline
2120

2221
# LLVM doesn't support instrumenting binaries that use SEH:
2322
# https://github.com/rust-lang/rust/issues/61002

0 commit comments

Comments
 (0)