Skip to content

Commit dedaebd

Browse files
committed
Auto merge of #30599 - brson:extra, r=alexcrichton
This mixes in additional information into the hash that is passed to -C extra-filename. It can be used to further distinguish the standard libraries if they must be installed next to each other. Closes #29559 Frankly, I'm not sure if this solves a real problem. It's meant to help with side-by-side and overlapping installations where there are two sets of libs in /usr, but there are other potential issues there as well, including that some of our artifacts don't use this extra-filename munging, and it's not something our installers can support at all. cc @jauhien Do you still think this helps the Gentoo case?
2 parents 4405944 + ce81f24 commit dedaebd

File tree

2 files changed

+2
-1
lines changed

2 files changed

+2
-1
lines changed

configure

+1
Original file line numberDiff line numberDiff line change
@@ -622,6 +622,7 @@ valopt aarch64-linux-android-ndk "" "aarch64-linux-android NDK standalone path"
622622
valopt nacl-cross-path "" "NaCl SDK path (Pepper Canary is recommended). Must be absolute!"
623623
valopt release-channel "dev" "the name of the release channel to build"
624624
valopt musl-root "/usr/local" "MUSL root installation directory"
625+
valopt extra-filename "" "Additional data that is hashed and passed to the -C extra-filename flag"
625626

626627
# Used on systems where "cc" and "ar" are unavailable
627628
valopt default-linker "cc" "the default linker"

mk/main.mk

+1-1
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ CFG_PRERELEASE_VERSION=.1
2222

2323
# Append a version-dependent hash to each library, so we can install different
2424
# versions in the same place
25-
CFG_FILENAME_EXTRA=$(shell printf '%s' $(CFG_RELEASE) | $(CFG_HASH_COMMAND))
25+
CFG_FILENAME_EXTRA=$(shell printf '%s' $(CFG_RELEASE)$(CFG_EXTRA_FILENAME) | $(CFG_HASH_COMMAND))
2626

2727
ifeq ($(CFG_RELEASE_CHANNEL),stable)
2828
# This is the normal semver version string, e.g. "0.12.0", "0.12.0-nightly"

0 commit comments

Comments
 (0)