Skip to content

Commit e9ca317

Browse files
committed
Revert "Auto merge of #136588 - ChrisDenton:no-msys2, r=Kobzol"
Seems like for whatever reason the msys2 installation here is needed for the 32-bit `i686-pc-windows-gnu`, otherwise `rustc` distributed for that target seems to link against the 64-bit libraries or sth. This revert is mostly just to buy time to investigate. This reverts commit e060723, reversing changes made to a9e7b30.
1 parent c03c38d commit e9ca317

File tree

1 file changed

+19
-0
lines changed

1 file changed

+19
-0
lines changed

Diff for: .github/workflows/ci.yml

+19
Original file line numberDiff line numberDiff line change
@@ -62,6 +62,9 @@ jobs:
6262
name: ${{ matrix.full_name }}
6363
needs: [ calculate_matrix ]
6464
runs-on: "${{ matrix.os }}"
65+
defaults:
66+
run:
67+
shell: ${{ contains(matrix.os, 'windows') && 'msys2 {0}' || 'bash' }}
6568
timeout-minutes: 360
6669
env:
6770
CI_JOB_NAME: ${{ matrix.name }}
@@ -77,6 +80,22 @@ jobs:
7780
# Check the `calculate_matrix` job to see how is the matrix defined.
7881
include: ${{ fromJSON(needs.calculate_matrix.outputs.jobs) }}
7982
steps:
83+
- if: contains(matrix.os, 'windows')
84+
uses: msys2/[email protected]
85+
with:
86+
# i686 jobs use mingw32. x86_64 and cross-compile jobs use mingw64.
87+
msystem: ${{ contains(matrix.name, 'i686') && 'mingw32' || 'mingw64' }}
88+
# don't try to download updates for already installed packages
89+
update: false
90+
# don't try to use the msys that comes built-in to the github runner,
91+
# so we can control what is installed (i.e. not python)
92+
release: true
93+
# Inherit the full path from the Windows environment, with MSYS2's */bin/
94+
# dirs placed in front. This lets us run Windows-native Python etc.
95+
path-type: inherit
96+
install: >
97+
make
98+
8099
- name: disable git crlf conversion
81100
run: git config --global core.autocrlf false
82101

0 commit comments

Comments
 (0)