Auto merge of #97756 - pietroalbini:pa-remove-azure-pipelines, r=Mark-Simulacrum

Remove Azure Pipelines configuration

This PR removes the remaining Azure Pipelines configuration, now that we fully removed all the resources on the Azure side of things.

Author: bors

.github/workflows/ci.yml

@@ -98,9 +98,6 @@ jobs:
       - name: install WIX
         run: src/ci/scripts/install-wix.sh
         if: success() && !env.SKIP_JOB
-      - name: ensure the build happens on a partition with enough space
-        run: src/ci/scripts/symlink-build-dir.sh
-        if: success() && !env.SKIP_JOB
       - name: disable git crlf conversion
         run: src/ci/scripts/disable-git-crlf-conversion.sh
         if: success() && !env.SKIP_JOB
@@ -496,9 +493,6 @@ jobs:
       - name: install WIX
         run: src/ci/scripts/install-wix.sh
         if: success() && !env.SKIP_JOB
-      - name: ensure the build happens on a partition with enough space
-        run: src/ci/scripts/symlink-build-dir.sh
-        if: success() && !env.SKIP_JOB
       - name: disable git crlf conversion
         run: src/ci/scripts/disable-git-crlf-conversion.sh
         if: success() && !env.SKIP_JOB
@@ -609,9 +603,6 @@ jobs:
       - name: install WIX
         run: src/ci/scripts/install-wix.sh
         if: success() && !env.SKIP_JOB
-      - name: ensure the build happens on a partition with enough space
-        run: src/ci/scripts/symlink-build-dir.sh
-        if: success() && !env.SKIP_JOB
       - name: disable git crlf conversion
         run: src/ci/scripts/disable-git-crlf-conversion.sh
         if: success() && !env.SKIP_JOB

src/ci/azure-pipelines/auto.yml

@@ -161,10 +161,6 @@ x--expand-yaml-anchors--remove:
         run: src/ci/scripts/install-wix.sh
         <<: *step
 
-      - name: ensure the build happens on a partition with enough space
-        run: src/ci/scripts/symlink-build-dir.sh
-        <<: *step
-
       - name: disable git crlf conversion
         run: src/ci/scripts/disable-git-crlf-conversion.sh
         <<: *step

src/ci/azure-pipelines/try.yml

@@ -1,9 +1,5 @@
 #!/usr/bin/env bash
 
-# FIXME(61301): we need to debug spurious failures with this on Windows on
-# Azure, so let's print more information in the logs.
-set -x
-
 set -o errexit
 set -o pipefail
 set -o nounset

src/ci/github-actions/ci.yml

@@ -1,6 +1,6 @@
 #!/bin/bash
 # Disable automatic line ending conversion, which is enabled by default on
-# Azure's Windows image. Having the conversion enabled caused regressions both
+# GitHub's Windows image. Having the conversion enabled caused regressions both
 # in our test suite (it broke miri tests) and in the ecosystem, since we
 # started shipping install scripts with CRLF endings instead of the old LF.
 #

src/ci/init_repo.sh

@@ -8,21 +8,6 @@ IFS=$'\n\t'
 
 source "$(cd "$(dirname "$0")" && pwd)/../shared.sh"
 
-# Since matrix variables are readonly in Azure Pipelines, we take
-# INITIAL_RUST_CONFIGURE_ARGS and establish RUST_CONFIGURE_ARGS
-# which downstream steps can alter
-if isAzurePipelines; then
-    # macOS ships with Bash 3.16, so we cannot use [[ -v FOO ]],
-    # which was introduced in Bash 4.2
-    if [[ -z "${INITIAL_RUST_CONFIGURE_ARGS+x}" ]]; then
-        INITIAL_RUST_CONFIG=""
-        echo "No initial Rust configure args set"
-    else
-        INITIAL_RUST_CONFIG="${INITIAL_RUST_CONFIGURE_ARGS}"
-        ciCommandSetEnv RUST_CONFIGURE_ARGS "${INITIAL_RUST_CONFIG}"
-    fi
-fi
-
 # Load extra environment variables
 vars="${EXTRA_VARIABLES-}"
 echo "${vars}" | jq '' >/dev/null  # Validate JSON and exit on errors

src/ci/scripts/clean-disk.sh

@@ -28,11 +28,7 @@ function retry {
 }
 
 function isCI {
-    [[ "${CI-false}" = "true" ]] || isAzurePipelines || isGitHubActions
-}
-
-function isAzurePipelines {
-    [[ "${TF_BUILD-False}" = "True" ]]
+    [[ "${CI-false}" = "true" ]] || isGitHubActions
 }
 
 function isGitHubActions {
@@ -63,9 +59,7 @@ function isCiBranch {
     fi
     name="$1"
 
-    if isAzurePipelines; then
-        [[ "${BUILD_SOURCEBRANCHNAME}" = "${name}" ]]
-    elif isGitHubActions; then
+    if isGitHubActions; then
         [[ "${GITHUB_REF}" = "refs/heads/${name}" ]]
     else
         echo "isCiBranch only works inside CI!"
@@ -74,10 +68,7 @@ function isCiBranch {
 }
 
 function ciBaseBranch {
-    if isAzurePipelines; then
-        echo "unsupported on Azure Pipelines"
-        exit 1
-    elif isGitHubActions; then
+    if isGitHubActions; then
         echo "${GITHUB_BASE_REF#refs/heads/}"
     else
         echo "ciBaseBranch only works inside CI!"
@@ -86,9 +77,7 @@ function ciBaseBranch {
 }
 
 function ciCommit {
-    if isAzurePipelines; then
-        echo "${BUILD_SOURCEVERSION}"
-    elif isGitHubActions; then
+    if isGitHubActions; then
         echo "${GITHUB_SHA}"
     else
         echo "ciCommit only works inside CI!"
@@ -97,9 +86,7 @@ function ciCommit {
 }
 
 function ciCheckoutPath {
-    if isAzurePipelines; then
-        echo "${BUILD_SOURCESDIRECTORY}"
-    elif isGitHubActions; then
+    if isGitHubActions; then
         echo "${GITHUB_WORKSPACE}"
     else
         echo "ciCheckoutPath only works inside CI!"
@@ -114,9 +101,7 @@ function ciCommandAddPath {
     fi
     path="$1"
 
-    if isAzurePipelines; then
-        echo "##vso[task.prependpath]${path}"
-    elif isGitHubActions; then
+    if isGitHubActions; then
         echo "${path}" >> "${GITHUB_PATH}"
     else
         echo "ciCommandAddPath only works inside CI!"
@@ -132,9 +117,7 @@ function ciCommandSetEnv {
     name="$1"
     value="$2"
 
-    if isAzurePipelines; then
-        echo "##vso[task.setvariable variable=${name}]${value}"
-    elif isGitHubActions; then
+    if isGitHubActions; then
         echo "${name}=${value}" >> "${GITHUB_ENV}"
     else
         echo "ciCommandSetEnv only works inside CI!"