Skip to content

test-float-parse: test staging #141920

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jieyouxu opened this issue Jun 2, 2025 · 4 comments
Open

test-float-parse: test staging #141920

jieyouxu opened this issue Jun 2, 2025 · 4 comments
Labels
A-floating-point Area: Floating point numbers and arithmetic A-test-infra Area: test infrastructure (may span bootstrap/compiletest/more) A-testsuite Area: The testsuite used to check the correctness of rustc T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Comments

@jieyouxu
Copy link
Member

jieyouxu commented Jun 2, 2025

No objection to the change here to unblock things, but it seems a bit unusual that this tool tests the beta std at all. Is there any way to change it to run on in-tree std with the beta and in-tree compilers?

Originally posted by @tgross35 in #141904 (comment)

@rustbot rustbot added the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label Jun 2, 2025
@jieyouxu jieyouxu added A-testsuite Area: The testsuite used to check the correctness of rustc C-enhancement Category: An issue proposing an enhancement or a PR with one. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) A-floating-point Area: Floating point numbers and arithmetic A-test-infra Area: test infrastructure (may span bootstrap/compiletest/more) and removed needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. labels Jun 2, 2025
@jieyouxu jieyouxu added C-bug Category: This is a bug. and removed C-enhancement Category: An issue proposing an enhancement or a PR with one. labels Jun 2, 2025
@tgross35
Copy link
Contributor

tgross35 commented Jun 2, 2025

Why is this test always such an edge case for everything 😆

In theory we could probably move it to a harness-less integration test in the std crate. IIRC dev dependencies can’t be made optional though so that’s kind of suboptimal for everyone who would want to run other tests without building test-float-parse’s large-ish dependency tree.

@onur-ozkan
Copy link
Member

We are not testing test-float-parse on beta std.

@jieyouxu
Copy link
Member Author

jieyouxu commented Jun 3, 2025

In theory we could probably move it to a harness-less integration test in the std crate. IIRC dev dependencies can’t be made optional though so that’s kind of suboptimal for everyone who would want to run other tests without building test-float-parse’s large-ish dependency tree.

Is the intention that test-float-parse does not wish to support being run against beta std (to save the necessary cfg(not(bootstrap)) or cfg(bootstrap) if beta/in-tree std has differences)? I.e. ./x check src/etc/test-float-parse --stage=0 should error or sth, and ./x check --stage=0 should skip src/etc/test-float-parse?

@onur-ozkan onur-ozkan removed the C-bug Category: This is a bug. label Jun 3, 2025
@tgross35
Copy link
Contributor

tgross35 commented Jun 3, 2025

I don't think there is ever any purpose on running it against the beta std, since if it finds a problem that's not really actionable (hopefully this never happens), it's mostly for validating changes to the algorithms in-tree.

The default should probably be to run it against the fully current source (in-tree library + in-tree compiler). It would be nice to be able to run it against the in-tree library with a downloaded compiler. I'm not really sure how that translates to the new stages 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-floating-point Area: Floating point numbers and arithmetic A-test-infra Area: test infrastructure (may span bootstrap/compiletest/more) A-testsuite Area: The testsuite used to check the correctness of rustc T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Development

No branches or pull requests

4 participants